DataError on saving with some addresses about django-address HOT 4 CLOSED

This has to do with the character limit on the state field being 3 characters. In certain cases states will come back with the same name in the "long_name" and "short_name" property. I discovered this and tried out expanding the character limit on the state code field and it fixed the error, but I'm not sure this is the solution we want. Maybe we want to ignore the field if the value that comes back from Google is longer than 3 characters?

from django-address.

Hi there,

Indeed, you're correct in your assessment; extending the state code length allows the value to be stored. However, I think ignoring the value makes more sense, as we already have the long name stored, and if there is no shorter code to represent it then we shouldn't need to store anything.

I've modified the code to check for duplicate codes and ignore them. However an exception will still be raised if the short code is longer than the maximum allowed length and is not a duplicate of the longer name.

I've added some new unit-tests and checked that the address mentioned goes through correctly. Please let me know if it doesn't work for you.

Cheers,
Luke

from django-address.

That makes sense. Thank you!

from django-address.

You're very welcome, thanks for the input!

from django-address.