Git Product home page Git Product logo

Comments (18)

mac-s-g avatar mac-s-g commented on July 27, 2024 8

@RalfReddings i ported my changes over to the class_VD branch (AHK v1).
here's the diff

hope this helps.

fyi -
I noticed while porting changes over that FindDesktop and RemoveDesktop point to the same method. I'm guessing I broke RemoveDesktop, but none of my automations reference it so I never encountered the problem.

from vd.ahk.

mac-s-g avatar mac-s-g commented on July 27, 2024 5

I ran into the same issue.

I was was able to resolve issues for my personal workflows. you can see my changes here.

I didn't post an MR for a couple of reasons:

  1. the changes generically target win11 build 22621. I don't know enough to isolate >= 2215 patch.
  2. I only tested VD.ah2 methods that I use personally (namely getCurrentDesktopNum, getCount, goToDesktopNum and MoveWindowToDesktopNum). Further changes are likely required to support all methods.
  3. I only made changes to the v2_port branch

It was a headache tracking down the updated interface id's. @MScholtes Virtual Desktop project is an amazing reference. thanks to him and @FuPeiJiang for their contributions to open source. hopefully my commit is useful for others. ❀️

from vd.ahk.

messmerizaRB avatar messmerizaRB commented on July 27, 2024 5

@RalfReddings i ported my changes over to the class_VD branch (AHK v1). here's the diff

hope this helps.

fyi - I noticed while porting changes over that FindDesktop and RemoveDesktop point to the same method. I'm guessing I broke RemoveDesktop, but none of my automations reference it so I never encountered the problem.

Thanks so much for this fix!

from vd.ahk.

zhcqiu avatar zhcqiu commented on July 27, 2024 4

I encountered the same issue. VD.ahk can't be used anymore.

from vd.ahk.

RalfReddings avatar RalfReddings commented on July 27, 2024 4

Me and my friend are on AHK V1 and can confirm that the update has broke it too. Any chance of a fix for V1 too?

from vd.ahk.

youderian avatar youderian commented on July 27, 2024 1

@mac-s-g Thank you so much! That fixed things for my use case (MoveWindowToDesktopNum, goToDesktopNum). Really appreciate your work and taking the time to share.

from vd.ahk.

daveM246 avatar daveM246 commented on July 27, 2024 1

Thanks @mac-s-g . I had to further modify VD.ah2 to get it to work on my windows 11 build 22621.
Lines 65 and 66 changed to:
this.Ptr_CreateDesktop := this._vtable(this.IVirtualDesktopManagerInternal.Ptr, 10)
this.Ptr_RemoveDesktop := this._vtable(this.IVirtualDesktopManagerInternal.Ptr, 12)

from vd.ahk.

bgriffy avatar bgriffy commented on July 27, 2024

I encountered the same issue. 😭

from vd.ahk.

youderian avatar youderian commented on July 27, 2024

I'm having the same issue!

from vd.ahk.

messmerizaRB avatar messmerizaRB commented on July 27, 2024

Same issue, Also looks like VirtualDesktop.cs has a newer version. I tried replacing that but it seems the UUID have changed. Awesome script by the way, it makes moving current windows between VDs so easy. so PLEASE FIX :-)

from vd.ahk.

theb0ringdev avatar theb0ringdev commented on July 27, 2024

Just updated and yes it stopped working. I don't know enough to fix it so I am hoping it will be fixed soon πŸ™ windows is a pain to use without this.

from vd.ahk.

anxxx avatar anxxx commented on July 27, 2024

Has worked perfectly until latest Windows updates (KB5031217) and (KB5030219) installed last night

Now receive error message when I attempt to switch desktops:


Error: This value of type "Class" has no property named "GetDesktops".

---- D:\Data\AutoHotkey2\VD2\VD.ah2
084: {
085: IObjectArray := 0

β–Ά 086: DllCall(this.GetDesktops, "UPtr", this.IVirtualDesktopManagerInternal.Ptr, "Ptr", 0, "UPtr*", &IObjectArray := 0)
087: Return IObjectArray
088: }

Any solution would be greatly appreciated.

from vd.ahk.

anxxx avatar anxxx commented on July 27, 2024

@mac-s-g Many many thanks and for finding a solution so quickly. Your changes work perfectly with Windows build 22621.2283. Having just programmed a Stream Deck keyboard to enable me to switch desktops and move apps with a single keystroke I was distraught that it was no longer working. Anyway, you have saved the day - at least until the next Windows update!

from vd.ahk.

Michael-Steshenko avatar Michael-Steshenko commented on July 27, 2024

My scripts based on _VD.ahk also stopped working, waiting for a solution.
The solution from @mac-s-g seems temp and modifies a file with a different name.

from vd.ahk.

mac-s-g avatar mac-s-g commented on July 27, 2024

thanks for the fix @daveM246! i committed the change to my v2_port branch and it resolved an error that cropped up recently.

from vd.ahk.

Stan-Stani avatar Stan-Stani commented on July 27, 2024

I replaced the first 92 lines into my current VD.ah2 and now it works. Thanks @daveM246 and @mac-s-g !

v2_port...mac-s-g:VD.ahk:v2_port

Edit

The reason I only replaced those lines was because I had an older commit checked out due to #53 . (I'm not sure if it's the one I posted or actually 7978eb5)

But after booting up today I was only getting errors for VD.ah2 so ended up just checking v2_port current again and replacing VD.ah2 with your version and now it's working. Thanks!
a
** Edit 2**
It stopped working... I finally figured out that for some reason the changes after that commit I posted above makes using the Arrow Keys not work. E.g.

^#left::VD.goToDesktopNum(1)
^#down::VD.goToDesktopNum(2)
^#right::VD.goToDesktopNum(3)
^#up::VD.goToDesktopNum(4)

does not work.

So I substituted

^#J:: VD.goToDesktopNum(1)
^#K:: VD.goToDesktopNum(2)
^#L:: VD.goToDesktopNum(3)
^#I:: VD.goToDesktopNum(4)

and now they're working fine.

from vd.ahk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.