Incorrect db key in the ClaimRepository contract about contracts HOT 8 CLOSED

We just discussed this internally. We confirm that this is indeed a bug in the current version of the platform.

We will however decline the current PR, as it is not a vulnerability, but rather just a bug.

We are prepared to grant a minor bounty if you fix this issue for us. We request that you just remove the functionality where

• we write to the counter
• read from the counter
• remove the tests for the counter (if they exist)

We don't use the counter (it's a remnant from a previous version) and the public constant function can just be removed. You'll be able to claim the minor bounty once the platform is live on mainnet.

from contracts.

Hi @Qkyrie roger that. Given this leads to a loss (i.e., non-capture) of data I think it entered the criteria for the bounty. But agree 100% it's not a security breach, and very happy that you still recognize the value of this input.

Will definitely proceed with the removal of that buggy functionality.

Note that even though this is not used, this still consumes gas, and the removal will hence decrease overall transaction cost 💪

from contracts.

perfect! 👍

from contracts.

This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g. fixes #50

• For more help on how to claim on issue, please visit our help section.
• Looking for more? Feel free to browse through all funded requests.

from contracts.

Thank you @thomasvds for your code contribution. You can now claim the reward that is linked to this issue. This can be done directly from the funded request.

• Looking for more? Feel free to browse through all funded requests.

from contracts.

Thank you @thomasvds for your code contribution. You can now claim the reward that is linked to this issue. This can be done directly from the funded request.

• Looking for more? Feel free to browse through all funded requests.

from contracts.

Thank you @thomasvds for your code contribution. You can now claim the reward that is linked to this issue. This can be done directly from the funded request.

• Looking for more? Feel free to browse through all funded requests.

from contracts.

Thank you @thomasvds for your code contribution. You can now claim the reward that is linked to this issue. This can be done directly from the funded request.

• Looking for more? Feel free to browse through all funded requests.

from contracts.