Git Product home page Git Product logo

Comments (10)

topher-lo avatar topher-lo commented on August 15, 2024 1

This makes sense 👍

from functime.

baggiponte avatar baggiponte commented on August 15, 2024 1

Should I make the PR?

from functime.

topher-lo avatar topher-lo commented on August 15, 2024 1

Let's do it. Also need to update the badges in the readme

from functime.

baggiponte avatar baggiponte commented on August 15, 2024

Finally time to get back to this. I am preparing a PR. One more thing: since we remove py3.8, we can rework a bit the type hints - no need to import List from typing, we can annotate with bare list. Can I work on those too? Should I create a separate PR for that? ruff can do quick work of those.

from functime.

baggiponte avatar baggiponte commented on August 15, 2024

@topher-lo I think I shall also open another PR to take care of the type annotations currently in place. As I was writing: "since we remove py3.8, we can rework a bit the type hints - no need to import List from typing, we can annotate with bare list". Do you agree with that?

from functime.

topher-lo avatar topher-lo commented on August 15, 2024

This would be a breaking change, so let's bundle this PR with 0.10.

from functime.

baggiponte avatar baggiponte commented on August 15, 2024

Why would you say it's a breaking change? It's the internal API. But sure!

from functime.

baggiponte avatar baggiponte commented on August 15, 2024

Also I forgot to update the badges in the README 😱 How do I generate it from shields.io?

from functime.

topher-lo avatar topher-lo commented on August 15, 2024

Users currently using 3.8 when they run pip upgrade functime, an error will occur

from functime.

baggiponte avatar baggiponte commented on August 15, 2024

Will postpone this until Py38 actually becomes unsupported (i.e., once 3.13 comes out). I think it's good to support the same Pyversions as polars does.

from functime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.