Proposal: Add details in error output about grpcurl HOT 2 CLOSED

@HT808s, I think this is a great idea. The only reason grpcurl doesn't show it now was more-or-less pure oversight.

I think it will be a bit tricky though. The Details() method of status won't be useful because it uses the default logic in github.com/golang/protobuf/ptypes to unmarshal the Any messages, which relies on linking generated code into the binary. Since grpcurl does not link with any such generated code (except for the few google.protobuf proto packages for descriptors and well-known types), you'll most likely just get a list of errors about not being able to resolve the actual message type.

So what I think is actually necessary follows:

1. Get the underlying google.protobuf.Any messages for the details.
2. For each one, parse out the fully-qualified message name. Use the DescriptorSource to get descriptor details for that message type (this will ask the server via the reflection interface or look at local proto files).
3. If you can get a descriptor, then from there you can use functions in github.com/jhump/protoreflect/dynamic to unmarshal the message and then format it as JSON.
4. If you cannot get a descriptor, then I think we should just show the String()-ified proto or perhaps a custom JSON form that shows the @type attribute but then also shows a @value attribute as the base64-encoded binary value.

If you're still willing to tackle a PR, I'll review it. But I can also probably get to this sometime this week, maybe even later today.

from grpcurl.

@jhump Thanks for your detailed reply!

I am not familiar with the inner of proto messages unmarshaling so this was instructive!
It's fine by me if you want to tackle it!

from grpcurl.