SIGSEGV: panic: runtime error: invalid memory address or nil pointer dereference in v1.8.8 about grpcurl HOT 16 CLOSED

This is definitely going to be a @jhump question

from grpcurl.

Sorry for the breakage. This was something that didn't have adequate test coverage in protoreflect and has unfortunately been broken since v1.15.0 (even the first release candidate).

I should have a fix and a new release of protoreflect this week.

from grpcurl.

This should be fixed as of v1.15.3 of protoreflect. @mprimeaux, could you please verify?

from grpcurl.

@mprimeaux I think we'd have to make another point release first to be able to do that

from grpcurl.

@mprimeaux here's the PR to update the version in Homebrew: Homebrew/homebrew-core#152288
As soon as it's merged, you'll be able to download the new release directly from Homebrew.

from grpcurl.

I suspected based on the stack trace but could have been our use of it. I’ll open an issue in the protoreflect repository and reference this issue.

from grpcurl.

As another data point, the above failing grpcurl command succeeds if I add -import-path ../internal/api to the command line, which now makes sense based on this line in grpcurl/desc_source.go.

Also, I pulled down the protoreflect code and wrote a new test using the same failing .proto file and it parses it just fine; no SIGSEGV panic.

After further debugging, I was able to simulate the exact panic by setting InferImportPaths to true on the protoparse.Parser.

Now that I have a failing test in protoreflect, I'll move the discussion fully over there.

from grpcurl.

@jhump I compiled grpcurl against protoreflect v1.15.3, tested various scenarios, and can confirm the fix works for this specific issue. Thanks for helping.

from grpcurl.

@dragonsinth I executed the updatedeps make target for the PR. If you prefer me to only upgrade protoreflect then please let me know. Happy to go that route, also.

from grpcurl.

Thanks @dragonsinth. Sincerely appreciate your help and support.

I'm not familiar with the process of updating the grpcurl brew formula. Should I open a PR over in this repo.

from grpcurl.

CC: @gpassini who's knowledge of this is fresher (no rush, whenever you're back)

from grpcurl.

Thanks much. I've got a workaround as stated above so no rush.

Again, appreciate your help and support.

from grpcurl.

this is pretty confusing to new users. So glad to have a workaround but any timeline on the release?

from grpcurl.

Sorry for the delay. The version 1.8.9 is now released!
https://github.com/fullstorydev/grpcurl/releases/tag/v1.8.9

from grpcurl.

Thanks, @gpassini. Will the brew formula also be updated in the near future? Again, thanks for your help.

from grpcurl.

Yes, I had an issue opening the update PR with Homebrew that I'm looking how to solve. But in the worst case they have some jobs that update formulas automatically. I'd say tomorrow it'll be updated either way.

from grpcurl.