Upgrade `commander` dependency about fuels-ts HOT 8 CLOSED

by the way, when I run tests on latest master, I get the same errors
And some other errors because of incorrect usage of Command and program from commander:
packages/fuels/src/cli/commands/withBinaryPaths.test.ts:

1 import { program } from 'commander';
15 const command = program
16     .command(Commands.versions)

It is not creating new command, but rather use the global one. That leads to such error messages:
Error: cannot add command 'versions' as already have command 'versions'
For me seems better way is:

1 import { Command } from 'commander';
15 const command = new Command()
16     .command(Commands.versions)

from fuels-ts.

hello, I can try it

@YaTut1901 Go for it! If you need any help, don't hesitate to ask 😄

from fuels-ts.

@petertonysmith94, I am running tests with bumped dependency and they are failing because of commands clashing. Here it is, in file packages/fuels/src/cli.ts:

45: const pathOption = new Option('-p, --path <path>', 'Path to project root').default(process.cwd());
58: .addOption(new Option(`-p, --predicates ${arg}`, `${desc} Predicates`).conflicts('workspace'))

updated commander doesn`t want to accept same options "-p", should they be renamed?

from fuels-ts.

@petertonysmith94, I am running tests with bumped dependency and they are failing because of commands clashing. Here it is, in file packages/fuels/src/cli.ts:

45: const pathOption = new Option('-p, --path <path>', 'Path to project root').default(process.cwd());
58: .addOption(new Option(`-p, --predicates ${arg}`, `${desc} Predicates`).conflicts('workspace'))

updated commander doesn't want to accept same options "-p", should they be renamed?

@YaTut1901 Great catch!

Not sure how this hasn't been an issue before, as they are conflicting flags. I'd suggest changing the path option to be capital P, as I would guess this would be a less breaking change to end users.

const pathOption = new Option('-P, --path <path>', 'Path to project root').default(process.cwd());

from fuels-ts.

Oh wow, how come did this get this far? 🤦‍♂️

@petertonysmith94 I'd say we don't need a shortcut for path, so it can be just --path. In my experience, the --path option is not very used, and having a case where we'd have -P and -p simultaneously may look weird. It works, but we can avoid it and favor clarity over brevity.

It is good to note that this will be a [small] breaking change.

from fuels-ts.

hello, I can try it

from fuels-ts.

@petertonysmith94 is there any other issues need to be completed?

from fuels-ts.

@YaTut1901 Check out the good first issues - just pop a message on the issue :D

from fuels-ts.