Improve `Predicate` class's type inference about fuels-ts HOT 9 CLOSED

@Dhaiwat10 @nedsalk Can we close this?

from fuels-ts.

@Dhaiwat10 summed it up nicely in #1867 (comment). Typescript inferring string[] instead of [string] for ['0xabc'] is default behavior, but it'd be superseded by the generated typegen type which would constrain it to [string].

from fuels-ts.

@arboleya yes, as @petertonysmith94 showcased PredicateParams<T> can already take in a generic which is used to type-constrain the inputs.

from fuels-ts.

Since we expect the data to satisfy the InputData[] shape, I can't see how it could be a non-array.

Unless we'd define it as InputData | InputData[], it all depends on how this is expected on the Sway side of things.

cc @nedsalk

from fuels-ts.

I wonder if #1867 wouldn't also close this issue.

cc @petertonysmith94

from fuels-ts.

@arboleya It doesn't close this issue.

#1867 references added the known types from the given generated ABI, and I believe this is referencing infer the types at a class level.

from fuels-ts.

Out of curiosity - how often is the API consumed in this way - whereby, the user isn't using the typegen?

bytecode = fs.readFile(...)
new Predicate({ bytecode, ... })

from fuels-ts.

This is not recommended, so I'd say almost never.

from fuels-ts.

I'd favour not implementing this change.

The typegen is adding known types to the predicate, therefore, this change only benefits users on this alternative instantiation path. IMO the following type inference is adequate for non-typegen instantiation.

or they may add the type themselves for a typed experience.

from fuels-ts.