Database driver and ORM Model update() inconsistency about core HOT 6 CLOSED

Was away most of today. No time to fully look into this tonight but it sounds logical. On the other hand, the affected row count from Model::update() should always be 1. If it's not something went wrong (Model::update() only updates the current instance, no others)

from core.

If you (with MySQL) fetch a record using Model::find(1) and then directly save it, affected rows is zero (update went ok, but no rows were updates since all values were the same).

If your controller contains a

if ($model->save())
{
    // success
}
else
{
    // failure
}

Your application will generate an error if the user requests a record, and clicks save without changing anything.

from core.

Actually, is_changed() is run before save() is executed and when no change is detected it will always return true

from core.

Issue is in typing. MySQL stores everything as string, so when you retrieve a record, all column values are strings, However, the fields on my forms and the validation routines behind it aren't, so an int column which was retrieved as "10", will be set to 10 (int!) before calling save(), and I assume that is_changed() will then return true, although for MySQL still nothing has changed.

from core.

I just changed Orm\Query::update() to return true when affected rows is 0. fuel/orm@42e17df6

from core.

Thanks. This can be closed then.

from core.