When used in MonoDevelop creates many connections. about sqlprovider HOT 6 CLOSED

Ok - I thought I had some connection managing code in the design-time stuff, but perhaps not. It's odd this has not been encountered up until now though. I will have a look at this later today, thanks

from sqlprovider.

Thanks. If you need/want any help I'm happy to build and test any patches.

from sqlprovider.

As a work around I'm caching IDbConnections in createTypes. It should probably be keyed on provider type as well as connection string but the following works for me:

diff --git a/src/SQLProvider/SqlDesignTime.fs b/src/SQLProvider/SqlDesignTime.fs
index 64b41b0..840b502 100644
--- a/src/SQLProvider/SqlDesignTime.fs
+++ b/src/SQLProvider/SqlDesignTime.fs
@@ -29,11 +29,11 @@ type SqlTypeProvider(config: TypeProviderConfig) as this =
     let sqlRuntimeInfo = SqlRuntimeInfo(config)
     let ns = "FSharp.Data.Sql";   
     let asm = Assembly.GetExecutingAssembly()
+    let connections = System.Collections.Concurrent.ConcurrentDictionary<string,IDbConnection>()

     let createTypes(conString,dbVendor,resolutionPath,individualsAmount,useOptionTypes,owner, rootTypeName) =       
         let prov = Common.Utilities.createSqlProvider dbVendor resolutionPath owner
-        let con = prov.CreateConnection conString
-        con.Open()
+        let con = connections.GetOrAdd(conString, (fun cs -> let con = prov.CreateConnection cs in con.Open(); con))
         prov.CreateTypeMappings con

         let tables = lazy prov.GetTables con

from sqlprovider.

This should hopefully be fixed now within here fba62ce

I changed the connection life cycles to be much more explicit in general - plus there was a key connection.Close() missing from the design-time code which is likely what was causing your issue. Please give it a go and let me know you get on, I made massive changes here to fix other stuff as well so all testing feedback is much appreciated, thanks!

from sqlprovider.

I ran into an issue when using count that the connection wasn't open. My commit Frassle@08134e1 seems to have fixed it.

The issue with too many connections does seem to have been fixed though :)

from sqlprovider.

Ahh, thanks, good shout. I missed that one. I have remade that change my side as it's just the single line. Let me know if you run into any other issues.

from sqlprovider.