Issue Summary While testing out F# for WebApi development I picked

SqlEnumProvider breaks VS 2019 about fsharp.data.sqlclient HOT 2 OPEN

bigby-the-wolf commented on August 15, 2024

SqlEnumProvider breaks VS 2019

from fsharp.data.sqlclient.

Comments (2)

smoothdeveloper commented on August 15, 2024 1

@MrGodlike6 thanks for the extensive bug report.

What I remember on top of my head is that SqlEnumProvider relies on some ADO.NET APIs that the two other type providers are not relying on:

FSharp.Data.SqlClient/src/SqlClient.DesignTime/SqlEnumProvider.fs

Lines 65 to 82 in eb45a54

 member internal this.CreateRootType( typeName, query, connectionStringOrName, provider, configFile, kind: SqlEnumKind) = 

 let tempAssembly = ProvidedAssembly() 

 let providedEnumType = ProvidedTypeDefinition(tempAssembly, nameSpace, typeName, baseType = Some typeof<obj>, hideObjectMethods = true, isErased = false) 

 let connStr, providerName = 

 match DesignTimeConnectionString.Parse(connectionStringOrName, config.ResolutionFolder, configFile) with 

 | Literal value -> value, provider 

 | NameInConfig(_, value, provider) -> value, provider 

 #if !USE_SYSTEM_DATA_COMMON_DBPROVIDERFACTORIES 

 // not supported on netstandard 20? 

 raise ("DbProviderFactories not available" |> NotImplementedException) 

 #else 

 let adoObjectsFactory = DbProviderFactories.GetFactory( providerName: string) 

 use conn = adoObjectsFactory.CreateConnection() 

 conn.ConnectionString <- connStr 

 conn.Open()

It seems you are running under .net 5, but I'm not sure if it loads the provider which is compiled with USE_SYSTEM_DATA_COMMON_DBPROVIDERFACTORIES or not, which has impact on the code above.

Another thing is that SqlEnumProvider is the only one being a generative type provider (rather than erased one) and I'm not sure if it has impact on the usage of this library under .net 5 runtime.

I don't have time to investigate right now, but one thing to test would be if the code surounding db provider factories works properly outside the context of a type provider, and of course, running through the issue with debugger attached to the editor instanciating/running the provider.

Thanks again for the report and all the references.

from fsharp.data.sqlclient.

xperiandri commented on August 15, 2024

Looks like the provider must be compiled for the latest .NET in order to make this work
As .NET 6 has it https://docs.microsoft.com/en-us/dotnet/api/system.data.common.dbproviderfactories?view=net-6.0

from fsharp.data.sqlclient.

Recommend Projects

SqlEnumProvider breaks VS 2019 about fsharp.data.sqlclient HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	member internal this.CreateRootType( typeName, query, connectionStringOrName, provider, configFile, kind: SqlEnumKind) =
	let tempAssembly = ProvidedAssembly()

	let providedEnumType = ProvidedTypeDefinition(tempAssembly, nameSpace, typeName, baseType = Some typeof<obj>, hideObjectMethods = true, isErased = false)

	let connStr, providerName =
	match DesignTimeConnectionString.Parse(connectionStringOrName, config.ResolutionFolder, configFile) with
	\| Literal value -> value, provider
	\| NameInConfig(_, value, provider) -> value, provider

	#if !USE_SYSTEM_DATA_COMMON_DBPROVIDERFACTORIES
	// not supported on netstandard 20?
	raise ("DbProviderFactories not available" \|> NotImplementedException)
	#else
	let adoObjectsFactory = DbProviderFactories.GetFactory( providerName: string)
	use conn = adoObjectsFactory.CreateConnection()
	conn.ConnectionString <- connStr
	conn.Open()