Comments (4)
Should we also have a SpaceAfterColon? Or maybe just SpacesAroundColon to control both? And should those options be global? There's at least 4 different situations I can think of where the colon is used, and I don't think they all fit under the same setting:
- Type declaration in records and abstract members: (usually there's spaces around)
type T = {
A : int
B : string }
type IFoo =
abstract Prop : int
- Type annotations in return types: (usually there's spaces around)
let xs : int list = []
- Type annotations in arguments: (I've seen both spaces around, no spaces around, or just spaces after, I think the more common is the first one)
let replace from to (s:string) = s.Replace(from, to)
let replace from to (s: string) = s.Replace(from, to)
let replace from to (s : string) = s.Replace(from, to)
- Giving names to arguments in type declarations in abstract members: (usually there's no spaces around)
type IFoo =
abstract Foo : s:string * i:int -> unit
from fantomas.
[I responded a few hours ago, but my comment disappeared]
Should we also have a SpaceAfterColon? Or maybe just SpacesAroundColon to control both?
If we use SpacesAroundColon
, we have to implicitly assign value 0, 1, 2 and 3 for it. Using SpaceAfterColon is a bit easier.
And should those options be global?
How do we deal with locality? We may split options into categories e.g.
- Colons in type declarations (case 1 and 4)
- Colons in arguments' type annotations (case 2 and 3)
To be honest, I'm still puzzled about this option.
from fantomas.
My desire is to have something like this https://github.com/icsharpcode/NRefactory/blob/master/ICSharpCode.NRefactory.CSharp/Formatter/FormattingOptionsFactory.cs#L46 where there are at least a few idiomatic styles to choose from.
Unfortunately there is no such style in F# (and functional programming) yet.
from fantomas.
PageWidth is now 120 and SpaceBeforeColon is false, see FormatConfig.
from fantomas.
Related Issues (20)
- Add doc comments in SyntaxNode.fs giving an example of what each node looks like
- Process is reserved keyword
- Unable to format Fable line (cannot determine if Expr Paren Fantomas.Core.SyntaxOak+ExprParenNode is uppercase or lowercase) HOT 2
- Trivia after mutable keyword is missing HOT 1
- Formatting can depend on cursor position HOT 4
- Misplaced comment in "else if" HOT 3
- Fantomas does not support extended interpolated strings HOT 4
- Many Ifdefs seem to cause parse error HOT 1
- Unmatched '{' error when formatting the code HOT 2
- Using `--check` gives error "todo WhileBang" HOT 9
- Breaks shorthand lambda atomicity for lowercase method invocations
- Consider relaxing ASTTransformer treatment of ranges in record fields HOT 1
- Unable to format F# 8 extended interpolated strings with curly braces HOT 3
- Move editor config to library rather than tool HOT 6
- "Incomplete declaration of a static construct" which the F# compiler accepts HOT 2
- Multiline secondary constructor HOT 4
- Equals sign should only be on same line if last tuple is multiline HOT 2
- Return type should go on next line
- Invalid F# code after formatting HOT 1
- Formatting removes necessary additional closing brackets for multiline interpolated strings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fantomas.