Git Product home page Git Product logo

Comments (4)

ovatsus avatar ovatsus commented on May 14, 2024

Should we also have a SpaceAfterColon? Or maybe just SpacesAroundColon to control both? And should those options be global? There's at least 4 different situations I can think of where the colon is used, and I don't think they all fit under the same setting:

  1. Type declaration in records and abstract members: (usually there's spaces around)
type T = {
    A : int
    B : string }

type IFoo =
    abstract Prop : int
  1. Type annotations in return types: (usually there's spaces around)
let xs : int list = []
  1. Type annotations in arguments: (I've seen both spaces around, no spaces around, or just spaces after, I think the more common is the first one)
let replace from to (s:string) = s.Replace(from, to)
let replace from to (s: string) = s.Replace(from, to)
let replace from to (s : string) = s.Replace(from, to)
  1. Giving names to arguments in type declarations in abstract members: (usually there's no spaces around)
type IFoo =
    abstract Foo : s:string * i:int -> unit

from fantomas.

dungpa avatar dungpa commented on May 14, 2024

[I responded a few hours ago, but my comment disappeared]

Should we also have a SpaceAfterColon? Or maybe just SpacesAroundColon to control both?

If we use SpacesAroundColon, we have to implicitly assign value 0, 1, 2 and 3 for it. Using SpaceAfterColon is a bit easier.

And should those options be global?

How do we deal with locality? We may split options into categories e.g.

  • Colons in type declarations (case 1 and 4)
  • Colons in arguments' type annotations (case 2 and 3)

To be honest, I'm still puzzled about this option.

from fantomas.

dungpa avatar dungpa commented on May 14, 2024

My desire is to have something like this https://github.com/icsharpcode/NRefactory/blob/master/ICSharpCode.NRefactory.CSharp/Formatter/FormattingOptionsFactory.cs#L46 where there are at least a few idiomatic styles to choose from.

Unfortunately there is no such style in F# (and functional programming) yet.

from fantomas.

nojaf avatar nojaf commented on May 14, 2024

PageWidth is now 120 and SpaceBeforeColon is false, see FormatConfig.

from fantomas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.