Diff is always one line longer than it should be about fantomas-for-vs HOT 7 CLOSED

My sympathies.

from fantomas-for-vs.

Hi @cmeeren
I've implemented diff shrinking, so now the edit surface should be minimal.

Could you please update the extension and try it out?

from fantomas-for-vs.

Yes, this was on my to-do list.
It mostly has to do with diff-patching in Visual Studio.

https://github.com/deviousasti/fsharp-formatting-for-vs/blob/26d43ea3334313459e5c90d5fc64b513d2418313/src/FantomasHandler.cs#L122

This would ideally be a candidate for Replace instead of Delete+Insert which works, but figuring that out in an elegant way might be hard. I haven't spent too much time on it.

from fantomas-for-vs.

I have no idea how this works, but might it be so simple that you trim a single newline (\r\n or \n) from oldText and newText (if both end with the same type of newline)?

from fantomas-for-vs.

Hi, sorry about the delay in responding.
There's a set of deletes followed by a set of inserts. It's not easy to decide if a line has been truly removed, only for it to be put back. Fantomas sometimes deletes several lines worth of whitespace in one go. I'm mostly worried about edge cases which could crop up and eat someone's code.

Would you be interested in solving this with me over a Visual Studio live-share?

from fantomas-for-vs.

No worries about the delay, it's not like I'm a paying customer of a service 😅

I appreciate the invitation, but unfortunately I'm already at 120% capacity at the moment, and I think it'll stay that way for a while. 😩

from fantomas-for-vs.

Works excellently, thanks a lot! 🙌

from fantomas-for-vs.