xUnit analyzer emits errors on Property tests about fscheck HOT 6 CLOSED

OK, comment added: xunit/xunit#2748 (comment)

Please consider joining the discussion.

from fscheck.

What are the implications for FsCheck? Does the analyser also emit errors for the Property attribute? If so, what can we do about it?

Should we have this discussion here? Or would it be more appropriate to have it at xunit/xunit#2748?

from fscheck.

@ploeh

Does the analyser also emit errors for the Property attribute?

Why should it? It just complained about return type.

[Property(MaxTest = 250)]
public Property Merging_2_finite_adjacent_DateRanges_properties() {...}

Or did you mean something else?

from fscheck.

Or did you mean something else?

No, that's a fine example, thank you.

Can we do anything about this in FsCheck? As far as I can tell, this looks as though the xUnit.net analyser produces a false positive.

I suggest continuing the discussion there, or perhaps open a new xUnit.net issue. I'll be happy to jump in over there if my presence is desired.

from fscheck.

I am not very familiar with xUnit architecture, but currently it looks like FsCheck can do nothing.

IMO, the set of allowed types should be defined by TestCaseDiscovererAttribute.

Maybe it's indeed worth that you commen in the original issue.

from fscheck.

Looks like this was fixed in xunit's analyzers.

from fscheck.