Build fails if any files are edited or removed. about sdattool HOT 17 CLOSED

The files will also need to be removed from the text files that may reference them, like FileBlock.json and InfoBlock.json

Edit: actually, the recommended way to build without files, is to just remove them from the json files, since they control what gets included

from sdattool.

Sorry to reopen this, tried what you suggested, only made things worse

from sdattool.

from sdattool.

Same as before.
Heck, even trying to optomize without ANY edits will cause the error

from sdattool.

Also the write raw option is broken

from sdattool.

from sdattool.

If it helps, what I just did was take an unedited pokemon HGSS sdat, unpack it, then attempted rebuild without touching ANY files whist using the -o (Optimize) option.
Error is as follows.
C:\Users\Goji Goodra\Music\SDAT>python sdattool hgss.sdat -o -b
Building...
Traceback (most recent call last):
File "sdattool_main_.py", line 391, in
main()
File "sdattool_main_.py", line 384, in main
build(args)
File "sdattool_main_.py", line 321, in build
build_infoBlock(sdat)
File "sdattool\Sdat.py", line 478, in build_infoBlock
exec(f"sdat.infoBlock.write(sdat, sdat.infoBlock.{infoBlockGroup[i]}, ii)")
File "", line 1, in
File "sdattool\Sdat.py", line 82, in write
type[index].write(sdat)
File "sdattool\Sdat.py", line 120, in write
append_short(sdat, sdat.names[FILE].index(self.fileName))
ValueError: 'SEQ_PV001.sseq' is not in list

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "sdattool_main.py", line 393, in
raise Exception(e)
Exception: 'SEQ_PV001.sseq' is not in list

Note: This sdat was totally untouched. no files removed prior to rebuilding with -o

from sdattool.

from sdattool.

Lemme give it a try
brb

from sdattool.

Using the build option -b alone succeeds on unmodified folder
Using build option with any other option causes this same error
Building...
Traceback (most recent call last):
File "sdattool_main_.py", line 391, in
main()
File "sdattool_main_.py", line 384, in main
build(args)
File "sdattool_main_.py", line 321, in build
build_infoBlock(sdat)
File "sdattool\Sdat.py", line 478, in build_infoBlock
exec(f"sdat.infoBlock.write(sdat, sdat.infoBlock.{infoBlockGroup[i]}, ii)")
File "", line 1, in
File "sdattool\Sdat.py", line 82, in write
type[index].write(sdat)
File "sdattool\Sdat.py", line 120, in write
append_short(sdat, sdat.names[FILE].index(self.fileName))
ValueError: 'SEQ_PV001.sseq' is not in list

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "sdattool_main.py", line 393, in
raise Exception(e)
Exception: 'SEQ_PV001.sseq' is not in list

from sdattool.

To be honest, this tool seems to barely work at all.
Kirby Super Star Ultra's SDAT fails to unpack with this error showing up
C:\Users\Goji Goodra\Music\SDAT>python sdattool kssu.sdat -u
Unpacking...
Traceback (most recent call last):
File "sdattool_main_.py", line 391, in
main()
File "sdattool_main_.py", line 382, in main
unpack(args)
File "sdattool_main_.py", line 63, in unpack
unpack_fileBlock(sdat, args)
File "sdattool\Sdat.py", line 549, in unpack_fileBlock
write_sseq_to_midi(read_sseq(sdat), args, tempName)
File "sdattool\Midi.py", line 121, in write_sseq_to_midi
seq.commands[i].binary += cmd.argument.to_bytes(1, "big")
OverflowError: int too big to convert

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "sdattool_main.py", line 393, in
raise Exception(e)
Exception: int too big to convert

from sdattool.

And Kirby Squeak Squad just hangs on unpack with nothing appearing in an extracted folder

from sdattool.

I was getting the same error. I think a lot of things broke with the midi update. I still have that code in the dev branch, but for the time being, I rolled back to an earlier version, which should be more stable. I know it's not as optimal, but other tools can be used to edit SSEQ if needed, though this should allow the SDAT itself to be unpacked and rebuilt correctly.

from sdattool.

Better then nothing, I suppose

from sdattool.

from sdattool.

I'll give it a try
Will report in a few

from sdattool.

Edit: Tried just doing a removal edit of all music related data with the White 2 Sdat.
All building options results in this.

Building...
Traceback (most recent call last):
File "C:\Users\Goji Goodra\Downloads\TEMP\SDATTool_main_.py", line 391, in
main()
File "C:\Users\Goji Goodra\Downloads\TEMP\SDATTool_main_.py", line 384, in main
build(args)
File "C:\Users\Goji Goodra\Downloads\TEMP\SDATTool_main_.py", line 78, in build
sdat.infoBlock.load(sdat, json.load(infile))
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python39\lib\json_init_.py", line 293, in load
return loads(fp.read(),
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python39\lib\json_init_.py", line 346, in loads
return _default_decoder.decode(s)
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 42812 column 6 (char 1126879)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Users\Goji Goodra\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "C:\Users\Goji Goodra\Downloads\TEMP\SDATTool_main.py", line 393, in
raise Exception(e)
Exception: Expecting ',' delimiter: line 42812 column 6 (char 1126879)

from sdattool.