Git Product home page Git Product logo

Comments (3)

JayPanoz avatar JayPanoz commented on June 5, 2024

That’s most probably an issue with the default value on narrower/smaller screens. I’ve just checked a bigger font-size in a square-ish context, and you can see numbers are already overflowing a little bit because those markers are kinda “floating” out of the padding-left:

Capture d’écran 2019-10-15 à 18 29 43

This appears to be consistent with web rendering so I’m even wondering whether other apps are adding some sort of extra margin to protect against that. Anyways, it slipped through the cracks so I’ll try to fix this issue ASAP.

I don’t necessarily like the idea of using relative units for that (e.g. em) as the padding-left will increase with font-size but on the other hand, the number size will increase with font-size so I don’t really imagine there’s another option available.

Indeed their padding-left is the 40px HTML5 suggested rendering default, and this can happen in the largest font-sizes anyway so even absolute units won’t resolve this issue.

Capture below is using their default:

Capture d’écran 2019-10-15 à 18 46 06

from blitz.

JayPanoz avatar JayPanoz commented on June 5, 2024

So I made this change to the default:

/* LISTS */
ul,
ol {
margin: 1.5em 0;
padding-left: 2em;
}
@media amzn-mobi {
ul,
ol {
margin: 1em 0;
}
}
ol + ol,
ol + ul,
ul + ol,
ul + ul {
padding-left: 1em;
}

This will now be using the base font-size, multiply by 2 for lists (then use base font-size for nested lists).

If no one voices their disagreement, will merge later this week.

from blitz.

JayPanoz avatar JayPanoz commented on June 5, 2024

This change has been merged. Thanks again for the bug report.

from blitz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.