Intellisense not working (TS) about csstype HOT 5 CLOSED

@dmahnkopf That hack is already in 3.0.0-beta.1. Related #74

from csstype.

I have found the issue:

type Globals = "inherit" | "initial" | "revert" | "unset";

type SelfPosition = "center" | "end" | "flex-end" | "flex-start" | "self-end" | "self-start" | "start";

type AlignSelfProperty = Globals | SelfPosition | "auto" | "baseline" | "normal" | "stretch"// | string;

interface CSSTest {
    alignSelf?: AlignSelfProperty;
}

const style: CSSTest = {
    alignSelf: 'stretch'
};

When I comment out | string, the intellisense works as expected. So it looks like that adding string to the types ruins intellisense...

from csstype.

Oh, I missed that in the example. Should change it. Thanks for noticing. The spec tells us that align-self can use space separated keywords and we don't support that yet. That's why it falls back to | string. I've started a PR #22 where I aim to solve this.

I agree that autocompletion in VSCode should work even if it contains | string. But it doesn't and there's an issue for that. @andy-ms commented that TypeScript won't fix it either for some reason.

The type "foo" | "bar" | string is equivalent to the string type and now gets simplified early on. So all we see when querying the type checker for the type of x is string. So, this can't be fixed.

Hopefully we can make them reconsider.

from csstype.

Closing because autocompletion is in the hands of TypeScript and we can't do much about it.

from csstype.

@frenic, would you consider rewriting the concerned types as proposed in this TypeScript issue comment?

from csstype.