Comments (5)
@dmahnkopf That hack is already in 3.0.0-beta.1
. Related #74
from csstype.
I have found the issue:
type Globals = "inherit" | "initial" | "revert" | "unset";
type SelfPosition = "center" | "end" | "flex-end" | "flex-start" | "self-end" | "self-start" | "start";
type AlignSelfProperty = Globals | SelfPosition | "auto" | "baseline" | "normal" | "stretch"// | string;
interface CSSTest {
alignSelf?: AlignSelfProperty;
}
const style: CSSTest = {
alignSelf: 'stretch'
};
When I comment out | string
, the intellisense works as expected. So it looks like that adding string
to the types ruins intellisense...
from csstype.
Oh, I missed that in the example. Should change it. Thanks for noticing. The spec tells us that align-self
can use space separated keywords and we don't support that yet. That's why it falls back to | string
. I've started a PR #22 where I aim to solve this.
I agree that autocompletion in VSCode should work even if it contains | string
. But it doesn't and there's an issue for that. @andy-ms commented that TypeScript won't fix it either for some reason.
The type "foo" | "bar" | string is equivalent to the string type and now gets simplified early on. So all we see when querying the type checker for the type of x is string. So, this can't be fixed.
Hopefully we can make them reconsider.
from csstype.
Closing because autocompletion is in the hands of TypeScript and we can't do much about it.
from csstype.
@frenic, would you consider rewriting the concerned types as proposed in this TypeScript issue comment?
from csstype.
Related Issues (20)
- How to limit the StandardLonghandProperties[`propertyName`] type to valid strings? HOT 1
- CSS Typed OM support HOT 1
- Missing '-webkit-user-drag'
- Ability to use an object with the value representing the css type
- Support for Container Queries HOT 4
- Strict types HOT 4
- Add `text-wrap` / `textWrap` from CSS4 (Chrome 113)
- add return type of `getComputedStyle()`
- Idea to wrap types into element types?
- How to migrate from old version to latest version
- Missing '-webkit-column-gap'
- missing '-webkit-padding-after' and '-webkit-padding-before'
- mdn/data deprecated HOT 1
- Regarding documentation and site for csstype
- Which version is the current version? Is it v3.1.2 or v2.6.0
- [3.1.3] typing issue with @emotion/serialize HOT 8
- New version causes breaks in Definitely Typed package `mui-datatables`
- WebkitUserSelects will resolve to user-select but not to -webkit-user-select
- Is there a reason why vendor prefixes in IE start with a lowercase letter?
- feat: add `view-*` CSS properties
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csstype.