Git Product home page Git Product logo

Comments (6)

fregante avatar fregante commented on May 20, 2024

This is the source: https://github.com/bfred-it/object-fit-images/blob/master/index.js

What's broken exactly? OFI doesn't run at all and therefore object-fit isn't polyfilled, or the images disappear?

It's hard to find the issue without seeing your page/site

from object-fit-images.

JoshMoreno avatar JoshMoreno commented on May 20, 2024

from object-fit-images.

fregante avatar fregante commented on May 20, 2024

If it doesn't seem to run at all, either flickity is moving the images around or you're not waiting for the document to be ready. What's your initialization code? objectFitImages();?

from object-fit-images.

JoshMoreno avatar JoshMoreno commented on May 20, 2024

Thanks for your help @bfred-it , got it sorted out. Not a conflict. It seems that the DOM wasn't ready. I was using

document.addEventListener('DOMContentLoaded', function () {
    objectFitImages();
});

I added jQuery and used this instead and everything works as expected.

$(function(){
    objectFitImages();
});

I'll post back if I find a reliable way to get it working with vanilla JS. Unless you have any ideas?

Thanks again! Super helpful.

from object-fit-images.

JoshMoreno avatar JoshMoreno commented on May 20, 2024

So it was because I was using async that I was missing the DOMContentLoaded event. Using this helper function from http://youmightnotneedjquery.com/

function ready(fn) {
  if (document.readyState != 'loading'){
    fn();
  } else {
    document.addEventListener('DOMContentLoaded', fn);
  }
}

// and usage like so
ready(function(){
    objectFitImages();
});

Everything seems to be working as it should. Thanks again. Sorry my fault.

from object-fit-images.

fregante avatar fregante commented on May 20, 2024

Glad you got it sorted out, thanks for sharing your solution!

from object-fit-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.