Linting errors after converting to TypeScript about browser-extension-template HOT 5 CLOSED

@fregante commented on April 11, 2022 12:42 AM:

The code is just demo code and it will have to be deleted. It doesn't have to be correct (especially for the lint)

True, but I am seeing the same errors from @typescript-eslint/no-unsafe-assignment and @typescript-eslint/no-unsafe-call in my own code after deletion of the demo code, which suggests that there may be some general issue with the combination of a) how the template's extension stack and its dependencies are configured, and b) how its linters are configured. These complaints relating to implicit any types seem to indicate that there are some types not getting picked up by eslint. But this is strange, because I can clearly see them in places like node_modules/webext-options-sync/index.d.ts.

That import you mentioned incorrect, what you're missing are the types for webextension-polyfill.

You mean the import @david-tejada mentioned? I just tried npm add -D @types/webextension-polyfill but it didn't eliminate any of the linting errors. And if that is indeed needed in other circumstances, wouldn't it be worth mentioning in the readme.md in the paragraph about Typescript?

The last error is most likely a eslint cache error unfortunately, nothing I can fix.

Yeah, no worries - just thought I'd mention it in case you'd seen that weirdness before.

from browser-extension-template.

I can see now that importing browser like I did doesn't make any difference. I changed it back too import browser from "webextension-polyfill"; and I get no errors. Maybe it was something that I did before adding tsconfig.json and seemed to work. Anyway, you can check out my package.json to see if you're missing something. I got no linting errors here

from browser-extension-template.

I got rid of those errors using this line to import browser:

import * as browser from "webextension-polyfill";

from browser-extension-template.

The code is just demo code and it will have to be deleted. It doesn't have to be correct (especially for the lint)

That import you mentioned incorrect, what you're missing are the types for webextension-polyfill.

The last error is most likely a eslint cache error unfortunately, nothing I can fix.

from browser-extension-template.

True, but I am seeing the same errors from @typescript-eslint/no-unsafe-assignment and @typescript-eslint/no-unsafe-call in my own code after deletion of the demo code

Yeah that's unrelated to anything. Those are just lint rules, you can read their details on the typescript-eslint repo or you can disable them.

wouldn't it be worth mentioning in the readme.md in the paragraph about Typescript?

Absolutely not, using TypeScript here assumes you already know TypeScript. Running tsc already tells you to install that package.

from browser-extension-template.