block multiple file pickers [bounty: 2 XTR] about ancientbeast HOT 12 OPEN

On Windows/Chrome I was not able to use Ctrl+Shift+Meta+X to save a file. The hotkeys file from master shows that the hotkey is shift+ctrl+X.

AncientBeast/src/ui/hotkeys.js

Lines 66 to 72 in 471f146

	pressX(event) {
	if (event.shiftKey && event.ctrlKey) {
	this.ui.game.gamelog.save();
	} else {
	this.ui.btnExit.triggerClick();
	}
	}

In any case, I was able to find another shortcut for ctrl+s to save and this worked for me. To have two different shortcuts for the same action seems a bit redundant to me, though. I'm not sure why the other shortcut did not work.

AncientBeast/src/ui/hotkeys.js

Lines 10 to 15 in 471f146

	pressS(event) {
	if (event.shiftKey) {
	this.ui.btnToggleScore.triggerClick();
	} else if (event.ctrlKey) {
	this.ui.game.gamelog.save();
	} else {

I now have a save log file, but am still unable to replicate your bug.

1. I hold ctrl+meta+L for a few seconds and select my save file.
2. I press "Open" to open this save file.
3. The game loads successfully and there are no further "leftover" file selectors.

In your bug scenario, how does the process differ?

Seems I got stuck on another fork when looking at the hotkey. We have 2 because browsers. Once more testing is done might as well stick to just one and document it or showcase it in some hotkey page in-game eventually.

I'm on Linux and using Brave, so it might be a specific bug that won't affect most people, will make sure to specify this stuff in OP. You're free to pick another issue if you want, plenty labeled 'easy'.

from ancientbeast.

Trying to recreate. Using FF/Edge on Windows, I only get a single window to pop up at any time.

What's your OS/browser?

from ancientbeast.

Trying to recreate. Using FF/Edge on Windows, I only get a single window to pop up at any time.

What's your OS/browser?

@andretchen0 I'm on Linux/Brave.

from ancientbeast.

Can I contribute to this? I have not played this game before but I enjoy games and would like to try committing to open source and this looks simple enough to tackle.

from ancientbeast.

@tykm Sure, go for it. Assigning you in a bit.

from ancientbeast.

@DreadKnight I am unfamiliar with this codebase and the functionality behind logging, but from my understanding:

• When I am on this pre-match screen, I can press ctrl+win+L to load a log file
  

• And doing so will prompt this screen:
  

And in your case, holding the shortcut will open multiple file selectors, as opposed to my screenshot where there is only one open?

from ancientbeast.

@tykm It only opens multiple files if I open a save file in the picker, provided I've held the load hotkey a little longer.
You can get a save (log) file by playing and pressing Ctrl+Shift+X and then you use that back in a pre-match screen.

from ancientbeast.

I am unable to use the ctrl+shift+X hotkey to save a log file. Do I need to progress past a certain num of turns to save or am I in the wrong mode? I am using Windows and Chrome.

from ancientbeast.

I am unable to use the ctrl+shift+X hotkey to save a log file. Do I need to progress past a certain num of turns to save or am I in the wrong mode? I am using Windows and Chrome.

It should work instantly. Hotkey was remapped recently, but checking the file it seems it's Ctrl+Shift+Meta+X, though the idea was to drop Meta and it works even without Meta for me xD

https://github.com/CyberBishop/AncientBeast/blob/master/src/ui/hotkeys.js#L65

from ancientbeast.

Seems from conversation I opposed dropping the Meta, just went for a more suitable letter instead, my bad; #2160

from ancientbeast.

On Windows/Chrome I was not able to use Ctrl+Shift+Meta+X to save a file. The hotkeys file from master shows that the hotkey is shift+ctrl+X.

In any case, I was able to find another shortcut for ctrl+s to save and this worked for me. To have two different shortcuts for the same action seems a bit redundant to me, though. I'm not sure why the other shortcut did not work.

I now have a save log file, but am still unable to replicate your bug.

1. I hold ctrl+meta+L for a few seconds and select my save file.
2. I press "Open" to open this save file.
3. The game loads successfully and there are no further "leftover" file selectors.

In your bug scenario, how does the process differ?

from ancientbeast.

Sounds good

from ancientbeast.