[BUG] Type mismatch in xTimerCreate, xTimerCreateStatic, and vTimerSetReloadMode uxAutoReload parameters/returns (takes UBaseType_t, but documentation calls for BaseType_t) about freertos-kernel HOT 5 CLOSED

Sorry for the late reply, I should really check this folder more often :(. That pretty much just moves the issue. A lot of functions returning bools return a BaseType_t value (e.g. xTimerCreateTimerTask, xTimerGenericCommand, and xTimerIsTimerActive). I think the issue is one of consistency. They can be one or the other, but not mix. While unsigned might make more sense, that might become a deeper rooted change. The attached Git diff seemed to get rid of the checker warning for me (note: I didn't touch commented out code). It did trickle into a number of calls (all changing the uxAutoReload argument from UBaseType to BaseType): xTimerCreate xTimerCreateStatic vTimerSetReloadMode prvInitialiseNewTimer If you go the other way, I'm guessing you'd have a tone of API return types that you'd have to tweak throughout the code and documentation.

diff --git a/Middlewares/Third_Party/FreeRTOS/Source/include/timers.h b/Middlewares/Third_Party/FreeRTOS/Source/include/timers.h index cb721797..e0833c98 100644 --- a/Middlewares/Third_Party/FreeRTOS/Source/include/timers.h +++ b/Middlewares/Third_Party/FreeRTOS/Source/include/timers.h @@ -227,7 +227,7 @@ typedef void (*PendedFunction_t)( void *, uint32_t ); #if( configSUPPORT_DYNAMIC_ALLOCATION == 1 ) TimerHandle_t xTimerCreate( const char * const pcTimerName, /*lint !e971 Unqualified char types are allowed for strings and single characters only. */ const TickType_t xTimerPeriodInTicks, - const UBaseType_t uxAutoReload, + const BaseType_t uxAutoReload, void * const pvTimerID, TimerCallbackFunction_t pxCallbackFunction ) PRIVILEGED_FUNCTION; #endif @@ -357,7 +357,7 @@ typedef void (*PendedFunction_t)( void *, uint32_t ); #if( configSUPPORT_STATIC_ALLOCATION == 1 ) TimerHandle_t xTimerCreateStatic( const char * const pcTimerName, /*lint !e971 Unqualified char types are allowed for strings and single characters only. */ const TickType_t xTimerPeriodInTicks, - const UBaseType_t uxAutoReload, + const BaseType_t uxAutoReload, void * const pvTimerID, TimerCallbackFunction_t pxCallbackFunction, StaticTimer_t *pxTimerBuffer ) PRIVILEGED_FUNCTION; @@ -1246,7 +1246,7 @@ const char * pcTimerGetName( TimerHandle_t xTimer ) PRIVILEGED_FUNCTION; /*lint * uxAutoReload is set to pdFALSE then the timer will be a one-shot timer and * enter the dormant state after it expires. */ -void vTimerSetReloadMode( TimerHandle_t xTimer, const UBaseType_t uxAutoReload ) PRIVILEGED_FUNCTION; +void vTimerSetReloadMode( TimerHandle_t xTimer, const BaseType_t uxAutoReload ) PRIVILEGED_FUNCTION; /** * TickType_t xTimerGetPeriod( TimerHandle_t xTimer ); diff --git a/Middlewares/Third_Party/FreeRTOS/Source/timers.c b/Middlewares/Third_Party/FreeRTOS/Source/timers.c index 59b3840d..31ff661f 100644 --- a/Middlewares/Third_Party/FreeRTOS/Source/timers.c +++ b/Middlewares/Third_Party/FreeRTOS/Source/timers.c @@ -218,7 +218,7 @@ static void prvProcessTimerOrBlockTask( const TickType_t xNextExpireTime, BaseTy */ static void prvInitialiseNewTimer( const char * const pcTimerName, /*lint !e971 Unqualified char types are allowed for strings and single characters only. */ const TickType_t xTimerPeriodInTicks, - const UBaseType_t uxAutoReload, + const BaseType_t uxAutoReload, void * const pvTimerID, TimerCallbackFunction_t pxCallbackFunction, Timer_t *pxNewTimer ) PRIVILEGED_FUNCTION; @@ -281,7 +281,7 @@ BaseType_t xReturn = pdFAIL; TimerHandle_t xTimerCreate( const char * const pcTimerName, /*lint !e971 Unqualified char types are allowed for strings and single characters only. */ const TickType_t xTimerPeriodInTicks, - const UBaseType_t uxAutoReload, + const BaseType_t uxAutoReload, void * const pvTimerID, TimerCallbackFunction_t pxCallbackFunction ) { @@ -308,7 +308,7 @@ BaseType_t xReturn = pdFAIL; TimerHandle_t xTimerCreateStatic( const char * const pcTimerName, /*lint !e971 Unqualified char types are allowed for strings and single characters only. */ const TickType_t xTimerPeriodInTicks, - const UBaseType_t uxAutoReload, + const BaseType_t uxAutoReload, void * const pvTimerID, TimerCallbackFunction_t pxCallbackFunction, StaticTimer_t *pxTimerBuffer ) @@ -348,7 +348,7 @@ BaseType_t xReturn = pdFAIL; static void prvInitialiseNewTimer( const char * const pcTimerName, /*lint !e971 Unqualified char types are allowed for strings and single characters only. */ const TickType_t xTimerPeriodInTicks, - const UBaseType_t uxAutoReload, + const BaseType_t uxAutoReload, void * const pvTimerID, TimerCallbackFunction_t pxCallbackFunction, Timer_t *pxNewTimer ) @@ -439,7 +439,7 @@ Timer_t *pxTimer = xTimer; } /*-----------------------------------------------------------*/

yes, that is correct