has_entry drops additional has key/values silently about mocha HOT 6 CLOSED

I take your point. From memory, I think has_entry started life only accepting separate key and value arguments and then was enhanced to allow a Hash because it resulted in something that was easier to read. My gut reaction is to raise an exception if a Hash with multiple entries is used as an argument, but that seems a little harsh. I'll ponder it some more...

from mocha.

I would read a has_entry with multiple key, values to mean that the Hash has to contain at least those entries but will not fail if more entries are present.

from mocha.

It doesn't even do that currently.

from mocha.

It doesn't make any sense to me for has_entry to accept multiple entries. It just wouldn't read well. I'm reluctant to remove the possibility to supply a single entry Hash to has_entry, partly because I think it does read better than comma-separated key and value parameters. So I think this just leaves raising an exception as the best option. The exception would explain that you should use has_entries instead. I'll look at implementing this shortly.

from mocha.

Fixed in c3ffaa9. It would be good if someone could try it out before I release it. It may have to wait for a couple of other changes before release. Thanks for all your interest. Cheers, James.

from mocha.

@phillc I've now released v0.10.4 which includes this fix. If you're happy with the solution, can you please close this issue. Thanks, James.

from mocha.