Comments (7)
dhubler
commented on July 28, 2024
Simply put
If FreeCONF is asked to Accept or Respond in XML then I think FreeCONF
should send error.
Until
FreeCONF supports XML
…On Thu, Apr 13, 2023 at 2:19 PM Patrick Dumais ***@***.***> wrote:
I'm not 100% sure if this is RFC compliant but I think the logic would be
valid:
Restconf could default to always return data with yang-data+json.
Unless the client sends "Accept: yang-data+xml" and nothing else. In this
case, restconf would send the reply in xml.
bascically:
Client Accept Header What restconf returns
yang-data+json yang-data+json
yang-data+json and yang-data+xml yang-data+json
yang-data+xml yang-data+xml
something else 415 ?
So the logic is only based on the Accept header and not on the
Content-Type.
—
Reply to this email directly, view it on GitHub
<#33>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACA7TJQRGQLQG2QTPXIZDXBA7SBANCNFSM6AAAAAAW5OATBI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from restconf.
pdumais
commented on July 28, 2024
technically yes, but it would be better for us to continue to silently process it.
If I can have it my way, I would keep status quo until XML is supported. And I would say #32 would be more useful to start with.
from restconf.
dhubler
commented on July 28, 2024
#32 assumes you can read XML and today you cannot. Your assumption
FreeCONF can currently read XML I think is incorrect.
…On Thu, Apr 13, 2023 at 2:47 PM Patrick Dumais ***@***.***> wrote:
technically yes, but it would be better for us to continue to silently
process it.
If I can have it my way, I would keep status quo until XML is supported.
And I would say #32 <#32>
would be more useful to start with.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACA7RTROAWYG2KRKUSUWTXBBC45ANCNFSM6AAAAAAW5OATBI>
.
You are receiving this because you commented.Message ID:
***@***.***>
from restconf.
pdumais
commented on July 28, 2024
No, the other issue I raised had a comment abput that but it was incorrect. #32 is about adding functionality to parse xml.
I created 2 requests: one to read, the other to write.
from restconf.
dhubler
commented on July 28, 2024
when we had read and write
solution is obvious
when we have one w/o the other
i assume this is temporary and if you really need the branch on freeconf
github, we can keep that on a branch and you can do whatever you'd like
…On Thu, Apr 13, 2023 at 4:42 PM Patrick Dumais ***@***.***> wrote:
No, the other issue I raised had a comment abput that but it was
incorrect. #32 <#32> is about
adding functionality to parse xml.
I created 2 requests: one to read, the other to write.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACA7TGS2HHR3IA7IHNQHDXBBQLXANCNFSM6AAAAAAW5OATBI>
.
You are receiving this because you commented.Message ID:
***@***.***>
from restconf.
pdumais
commented on July 28, 2024
I just thought it was easier to divide the work in two. Since one item is about checking the contentType and acting on it. The other is about checking the Accept header.
If you prefer 1 single task, I'm good with it too It's your project :)
But I'm gonna explore how to parse XML on my side in the meantime.
from restconf.
dhubler
commented on July 28, 2024
dividing the work is always good
our project. my philosophy is once someone contributes to a certain level,
they get to do whatever they want. you could still convince me 1/2 is
better than none in master, but i suspect once you do half, you'll want to
finish and this won't be an issue.
…On Thu, Apr 13, 2023 at 5:17 PM Patrick Dumais ***@***.***> wrote:
I just thought it was easier to divide the work in two. Since one item is
about checking the contentType and acting on it. The other is about
checking the Accept header.
If you prefer 1 single task, I'm good with it too It's your project :)
But I'm gonna explore how to parse XML on my side in the meantime.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACA7VNS22OXVXNVFORNW3XBBUQBANCNFSM6AAAAAAW5OATBI>
.
You are receiving this because you commented.Message ID:
***@***.***>
from restconf.
Related Issues (20)
- when requesting xml, response is a truncated json response HOT 5
- Feature request: Support XMLparsing HOT 1
- ServeHTTP in server is not using Request context HOT 2
- Restconf server automatically opens a HTTP server HOT 1
- Feature request: Improve README HOT 1
- Feature request: Improve reflection support HOT 3
- Feature request: Improve error handling HOT 7
- Yang reference needs bump HOT 1
- Response content type not correctly set after XML pull request merge HOT 1
- local.go:ApplyStartupConfigFile function panics instead of returning an error HOT 2
- Restconf does not set the body in the right format (XML) for errors with a body when the accept in the request is XML HOT 2
- Restconf go.mod does not refer to latest freeconf/yang HOT 1
- Content-Type set in util::handle is overwritten by net/http/server.go HOT 1
- Response body for errors not valid in XML HOT 1
- Edit a leaf with `config false` HOT 2
- Question: how to post binary data with JSON HOT 3
- Bug in support for RFC 8525 HOT 3
- Question: how to view full config after change HOT 9
- Question: how to re-retrieve server configuration HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from restconf.