An alternate map_attribute API about datamappify HOT 9 CLOSED

@stevenharman what about:

using 'ActiveRecord' do
  map_attribute :account_username,  to: 'UserAccount#username'
end

Or using some nice convention over configuration defaults:

using 'ActiveRecord' do
  map_attribute :user_account__username
end

from datamappify.

I suppose wrapping the config in a block where you specify a local default provider is kind of nice for when you want to map many things at once. Though the more verbose :with option is also nice for a single, or just a few, mappings.

I don't really like the double underscore to denote the method name.

from datamappify.

I like the block level style, it is explicit, readable and doesn't require more keystrokes. :)

from datamappify.

So best of all worlds?
ie. allow using a block, or the more verbose single option. :)

Agreed, that double underscore doesn't look pretty...
How bout drying it up another way:

using 'ActiveRecord' do
  mapping 'UserAccount', :prefix => :account do
    map_attribute :username
  end
end

Or what about:

mapping 'UserAccount', :prefix => :account, :using => 'ActiveRecord' do
  map_attribute :username
end

from datamappify.

@fredwu, Number of keystrokes seems an odd thing to optimize for, over intent and clarity. 😉

@locochris, Remember:

DRY isn’t about the repetition of structure, it’s about the duplication of knowledge.

At any rate, of the block syntaxes, I prefer the last one, I think. Even then, the :using option could default to the specified default_provider.

❤️ for the communication and feedback, all.

from datamappify.

@stevenharman if you go with the default_provider idea it'd probably make more sense to
compliment that by using the word :provider instead of :using

from datamappify.

How about this?

with_provider :ActiveRecord do
  map_attribute :account_username, to: 'UserAccount#username'
end

# and

map_attribute :account_username, to: 'UserAccount#username', :with_provider: :ActiveRecord

from datamappify.

@fredwu That seems reasonable.

from datamappify.

FYI I'm going to let the :via option act the same way, in that case I think I will make it:

group :provider: :ActiveRecord, via: :user_id do
  map_attribute :account_username, to: 'UserAccount#username'
end

# and

map_attribute :account_username, to: 'UserAccount#username', :provider: :ActiveRecord, via: :user_id

from datamappify.