Git Product home page Git Product logo

Comments (7)

rboyatt avatar rboyatt commented on September 4, 2024

I think the changes are more extensive than the name of the results table. While preparing a patch to fix the results table, checked results pages and noticed that volunteer information wasn't appearing correctly. I think multiple volunteer roles have been renamed.

For example: Equipment Storage and Delivery was "Przechowanie sprzętu" but now appears to be "Przechowując(a)y wyposażenie", and Pre-event Setup was "Rozstawienie oznakowań" but now appears to be "Rozstawiając(a)y oznakowanie".

from running-challenges.

fraz3alpha avatar fraz3alpha commented on September 4, 2024

I should have looked at the checks sooner, there was a syntax error in the i18n file - a comma inside the quotes rather than outside, I'll fix it elsewhere

from running-challenges.

rboyatt avatar rboyatt commented on September 4, 2024

Apologies, that comma was my fault I think. Thanks for catching.

from running-challenges.

t3d avatar t3d commented on September 4, 2024

Unfortunately this "Parsing Results" freeze is still there (Firefox).

In the Inspector (or whatever the tool is called) I can see

TypeError: parkruns_completed_sorted[0] is undefined content-script-parkrunner.js:211:3
parse_results_table moz-extension://d625bc3a-809d-47c0-a492-235374a75e92/js/content-scripts/content-script-parkrunner.js:211
create_page moz-extension://d625bc3a-809d-47c0-a492-235374a75e92/js/content-scripts/content-script-parkrunner.js:526
moz-extension://d625bc3a-809d-47c0-a492-235374a75e92/js/content-scripts/content-script-parkrunner.js:659
inject resource://gre/modules/ExtensionContent.jsm:593
AsyncFunctionNext self-hosted:810

from running-challenges.

fraz3alpha avatar fraz3alpha commented on September 4, 2024

@t3d , which version of the extension were you trying this with? - one of the branch builds, i presume (as the code isn't in the released version yet)?

from running-challenges.

t3d avatar t3d commented on September 4, 2024

Oh, sorry, I'm using the 1.3.1.257. I just assumed this was released after the fix was done.

from running-challenges.

fraz3alpha avatar fraz3alpha commented on September 4, 2024

That's ok! I'm on holiday this week, we might be able to upload the fixed version unless we find anything else that is broken - so it's good news you were using the last released version

from running-challenges.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.