Git Product home page Git Product logo

Comments (12)

frankban avatar frankban commented on July 21, 2024

Hi artscoop,

currently there is no way to do that, thanks for suggesting this interesting use case.
I'd like to add this functionality, it should not be too much difficult.
Any suggestion on a clean API for this feature? paginate starting from page -1?

from django-endless-pagination.

artscoop avatar artscoop commented on July 21, 2024

Hello Francesco,
A negative number is a good idea, one could use -1 for the last page, -2 and so on.
This would allow the regex to stay clean and similar to list indexes.
If it seems good for you, a too negative index (ex. -20 when there are only 10 pages) should default to the last page.

from django-endless-pagination.

frankban avatar frankban commented on July 21, 2024

Hi artscoop,

agreed on using negative numbers. I am on it.
However, in the case of an out of range negative index, why do you think it should default to the last page?
Defaulting to the first page makes more sense to me: that's the default behavior already used when the requested page is out of range. What do you think? Am I missing something?
Thanks.

from django-endless-pagination.

frankban avatar frankban commented on July 21, 2024

First working implementation pushed to trunk. This feature is still undocumented.

from django-endless-pagination.

artscoop avatar artscoop commented on July 21, 2024

Oh nice, thank you so much !
I think an off limits negative index should reflect the same behaviour as positive integers, but starting with the last page in the list. Hence the last page when too negative. But this is not mandatory, since I can't see any use case for this.

from django-endless-pagination.

frankban avatar frankban commented on July 21, 2024

artscoop, my pleasure. Added documentation, closing this bug.

from django-endless-pagination.

artscoop avatar artscoop commented on July 21, 2024

Hi,
Sorry to revive this thread, but there is one more thing, a small bug with the feature:
When the starting index is negative, clicking the matching page in the page list should remove the URL query parameter.
Example:
You have a 5 page thread, autopaginated to start at the last page.
You add messages, this "creates" a new page which is displayed automatically without the need to click the pagination.
Then you click page 1.
Then you click page 6.
You add enough messages to reach a count of 7 pages.
But this time, you're still on page 6, which is wrong.

from django-endless-pagination.

frankban avatar frankban commented on July 21, 2024

Is Ajax involved in what you are reporting?

from django-endless-pagination.

artscoop avatar artscoop commented on July 21, 2024

Nope ! Just plain HTML.
The -n index does not equal the page index hence endless appending the ?page parameter

from django-endless-pagination.

frankban avatar frankban commented on July 21, 2024

Confirmed. When using negative indexes, the querystring is added to the path of the corresponding page when the page links are re-rendered after a page change.

from django-endless-pagination.

frankban avatar frankban commented on July 21, 2024

Hi artscoop,
this bug is now fixed in trunk.
Could you please confirm that everything is running well for you too?
Thanks.

from django-endless-pagination.

artscoop avatar artscoop commented on July 21, 2024

Hi again Frank,
I do confirm it is working well !
Thank you for your work.

from django-endless-pagination.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.