Comments (4)
ham1
commented on May 27, 2024
Maybe we can make it protected.
Is it a good idea to have another PageFactory which differs only in package name (I think it was a mistake for BaseTest)?
What happens if people use new PageObject.get() instead of PageFactory?
from frameworkium-core.
Mjl33
commented on May 27, 2024
We could have used another name, but decided to use the same name to avoid having to make junior devs relearn that this wrapper PageFactory does the same thing as the wrapped PageFactory.
Most do not realize they were benefiting from the wait for invisibility spinner. They were just told to use this PageFactory in the new package for all PageFactory call.
Since the name is familiar to what they were trained to use, they immediately associated it with old function.
from frameworkium-core.
Mjl33
commented on May 27, 2024
Merged https://github.com/Frameworkium/frameworkium-ui/commit/8461a101a7f9161bde937d22cf55491d5bcdc811
from frameworkium-core.
Mjl33
commented on May 27, 2024
Reopening this because this change needs to be in frrameworkium-core
from frameworkium-core.
Related Issues (20)
- ExtraExpectedConditions.sizeGreaterThan does not accept controls from ru.yandex.qatools.htmlelements.element
- JIRA logging does not work when a test is tagged with multiple TmsLink annotation
- Modify the default wait time for @Visible annotations HOT 2
- Should the UITestRunner have alwaysRun set on afterMethod? HOT 4
- Unable to run test in Edge
- winapp example HOT 1
- How to find if a web table text exists under a specific column, if the column is not a header? HOT 1
- Add release drafter
- Create issue template against documentation requests
- Capture does not recognize multiple TmsLink or Issue annotations per method
- Timeouts on master causing NoSuchMethodError HOT 1
- EventFiringWebDriver has been deprecated since selenium:4.0.0-beta2 HOT 1
- Remove internal implementation for Select
- @Name annotation throw default value exception HOT 1
- Unable to open chrome browser HOT 2
- Click on non-visible links by default HOT 1
- How to extend the BasePage HOT 1
- BasePageExtended causing issue with wait HOT 3
- jitpack failed to host artifact for latest release version HOT 4
- AllureLifecycle attach screenshot triggers before screenshot taken HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frameworkium-core.