Git Product home page Git Product logo

Comments (5)

dorono avatar dorono commented on July 18, 2024 1

@hieumt2 To elaborate on the discussion above, here is the method namespacing we would like to use in an effort to reflect most closely the structure of an API url :

apiInfo.get()
chains.get()
chains.create()
chains.list()
chains.search()
chains.entries.get()
chains.entries.getFirst()
chains.entries.getLast()
chains.entries.create()
chains.entries.list()
chains.entries.search()
identities.get()
identities.create()
identities.keys.list()
identities.keys.replace()
keyUtil.generatePair()
keyUtil.generatePairs() <- optional, but seems redundant to the above

Apologies for all of the back and forth and changes, getting very close now... :)

Thanks!

from factom-harmony-connect-js-sdk.

hieumt2 avatar hieumt2 commented on July 18, 2024

@dorono I believe

myChain.entry.getFirst() // defaults to true for checking validation
myChain.entry.getFirst({
signatureValidation: false
})

should be

myChain.entries.getFirst() // defaults to true for checking validation
myChain.entries.getFirst({
signatureValidation: false
})

since getFirst and getLast actually search for entry in entries

from factom-harmony-connect-js-sdk.

dorono avatar dorono commented on July 18, 2024

@hieumt2 Yes, you are right - good catch!

from factom-harmony-connect-js-sdk.

hieumt2 avatar hieumt2 commented on July 18, 2024

I will remove the keyUtil.generatePair() methods, we will use keyUtil.generatePairs() with default number of key pairs returns is 3.

from factom-harmony-connect-js-sdk.

hieumt2 avatar hieumt2 commented on July 18, 2024

Fixed in PR #27

from factom-harmony-connect-js-sdk.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.