Git Product home page Git Product logo

Comments (10)

MenacingPerson avatar MenacingPerson commented on August 29, 2024 2

I'm having this issue too.

from enhancedblockentities.

Sanluli36li avatar Sanluli36li commented on August 29, 2024 2

I tried only replaymod and ebe, same

from enhancedblockentities.

Johni0702 avatar Johni0702 commented on August 29, 2024

You need to go into Resource Packs and then reorder Vanilla to be above Fabric Mods, after which the glitch happens

This happens for me even without ReplayMod installed. So please do report this on Enhanced Block Entities' issue tracker.
As far as I can tell, that is all there is to this. EBE simply breaks when the bottom-most pack is anything other than the vanilla "Default" pack. It doesn't actually matter what's there instead - Fabric Mods, Programmer Art or ReplayMod's internal pack - it'll break in any case.

ReplayMod/ReplayMod#532 (comment)

from enhancedblockentities.

FoundationGames avatar FoundationGames commented on August 29, 2024

EBE has to override vanilla resources to work since it replaces vanilla resource files. Changing the resource pack selection so that the default resources override modded resources will break EBE and likely several other mods.
Issue was also noted as fixed in the latest ReplayMod release.

from enhancedblockentities.

Johni0702 avatar Johni0702 commented on August 29, 2024

EBE has to override vanilla resources to work since it replaces vanilla resource files. Changing the resource pack selection so that the default resources override modded resources will break EBE

But that's not what I said. EBE will break even when the relation between modded and vanilla pack is unchanged. It is enough for anything other than Vanilla to be the bottom most pack and EBE will break, even if that is an empty pack.

Issue was also noted as fixed in the latest ReplayMod release.

It was "fixed" in so far that ReplayMod no longer creates an invisible resource pack and therefore can no longer trigger this bug. The bug itself is in EBE and has nothing to do with RM (except that RM used to be one way to trigger it).

from enhancedblockentities.

FoundationGames avatar FoundationGames commented on August 29, 2024

EBE should not break as long as vanilla is below fabric mods and any additional pack above doesnt overwrite the chest blockstate files. Could you show an example of an arrangement that breaks EBE?

from enhancedblockentities.

Johni0702 avatar Johni0702 commented on August 29, 2024

I'm not guessing here. It's plainly obvious from looking at your code, EBE just inserts its pack at index 1, so if anything other than the Vanilla pack is at index 0, then your pack cannot possibly overwrite the vanilla blockstate files:

ImmutableList.Builder<ResourcePack> builder = ImmutableList.builder();
builder.add(old.get(0));
builder.add(ResourceUtil.getPack());
for (int i = 1; i < old.size(); i++) {
builder.add(old.get(i));
}
return builder.build();

from enhancedblockentities.

FoundationGames avatar FoundationGames commented on August 29, 2024

That actually makes sense
I believe I write that under the assumption that the vanilla resources stay at 0 and can't be moved

from enhancedblockentities.

Madis0 avatar Madis0 commented on August 29, 2024

Just to confirm, is this issue fixed with 0.5? @FoundationGames

from enhancedblockentities.

FoundationGames avatar FoundationGames commented on August 29, 2024

fixed in 0.5 yes

from enhancedblockentities.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.