Git Product home page Git Product logo

Comments (3)

FoundationGames avatar FoundationGames commented on July 25, 2024

Likely an issue with how Canvas applies material shaders, since the rendering of the chest lid directly emits quads to a vertex consumer. Will be looked into but is likely a fix Canvas has to implement.

from enhancedblockentities.

supsm avatar supsm commented on July 25, 2024

Is it possible to create a shader pipeline or something that changes this?

from enhancedblockentities.

spiralhalo avatar spiralhalo commented on July 25, 2024

This is an issue with AO. I don't have a full grasp of what is happening Java-side but on the shader-side the chest lid has an AO value of 0 or something close to 0.

Some facts:

  1. Canvas only computes AO for the terrain render context.
  2. When the AO isn't computed, it will be set to 255.
final int ao = aoData == null ? 255 : (Math.round(aoData[i] * 255));

If we go by those facts alone, perhaps the chest lid is rendered with terrain render context when it should be rendered with block entity render context. This is just a guess.

Despite this, the chest lid seems to be rendered against camera origin as opposed to render region origin like the terrain usual is.

If you want a shader side solution @supsm Lumi Lights already disabled vanilla AO for things rendered against camera origin (presumed to be entities). Similar fix can be applied to Canvas built in pipeline shader since the problem seems specific to Canvas but I'm not fully confident about the nature of this workaround.

from enhancedblockentities.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.