Git Product home page Git Product logo

Comments (15)

bobgob avatar bobgob commented on May 30, 2024

I just tested and the issue is not fixed. I get the same results as before.

from fossology.

bobgob avatar bobgob commented on May 30, 2024

sorry. My mistake. I was looking at a cached page. Closing.

from fossology.

bobgob avatar bobgob commented on May 30, 2024

Reopening. The Scanner Count did change but it does not match the number of files displayed in "List Files for License"

from fossology.

wuan avatar wuan commented on May 30, 2024

So i think we have a similar problem on the license_list_files page.

<total_count> files found (<unique_count> unique) with license <license_shortname>

Total count is again containing results of multiple agent versions.

from fossology.

bobgob avatar bobgob commented on May 30, 2024

That message was changed yesterday. Do a git pull.

from fossology.

bobgob avatar bobgob commented on May 30, 2024

In case there a misunderstanding of what the License Browser should be displaying, let me go over that. By default, only the latest results should be displayed. For example, say you have Monk 2.5.0, Monk 2.6.1, Nomos 2.5.0 and Nomos 2.6.1 scans. By default, the results for Monk 2.6.1 and Nomos 2.6.1 should be displayed. This should not include the 2.5.0 results. The pull down lets you recall older results.

from fossology.

wuan avatar wuan commented on May 30, 2024

The license_list_files page shows the unique file count in the beginning and the number of files listed is identical to the number of files with the particular license.
As I assume that the number of files (not unique files) is relevant here, I will try to fix this as well.

from fossology.

wuan avatar wuan commented on May 30, 2024

fixing the license_list_files page would be rather expensive, please file another issue if this is required.

from fossology.

bobgob avatar bobgob commented on May 30, 2024

My tests show that List Files for License and the License Browser Scanner count now agree with each other. Thank you!

from fossology.

yaobinshi avatar yaobinshi commented on May 30, 2024

for this commit 3128584

I have a question:
one file has multiple BSD-3-Clause license text, so monk will report multiple BSD-3-Clause for this file,
the 'Scanner Count' will count multiple times, so the file count may less than the 'Scanner Count'.
from my perspective, my check in is better on the notice description, or others?

from fossology.

wuan avatar wuan commented on May 30, 2024

The count displayed at the beginning of the license file list is the number of unique files having at least one appearance of the license. Whereas the file listing below counts unique files multiple times. Files with identical content are grouped together but counted individually.

If files with identical content exist in this view, the users may be irritated due to the different numbers.

from fossology.

yaobinshi avatar yaobinshi commented on May 30, 2024

Ok, why I asked the question above is because, I have one archive, 'Monk Scanner Count' is 5 BSD-3-Clause on license browser page, however the file count is 2 on List Files for License page, as one file is returned 4 BSD-3-Clause by monk, another file is return a BSD-3-Clause by monk.

from fossology.

wuan avatar wuan commented on May 30, 2024

The scanner count should count multiple licenses per file individually. Would this be the expected behaviour here?
The file list does not repeat files if the same license is found at multiple location. So we can expect differences in count.

from fossology.

yaobinshi avatar yaobinshi commented on May 30, 2024

Will talk with others to get more opinions, let us keep it. thanks.

from fossology.

mcjaeger avatar mcjaeger commented on May 30, 2024

Andreas' (wuan) sounds reasonable now, and since there has not been an update since 12 months, I am closing

from fossology.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.