Git Product home page Git Product logo

Comments (11)

SilentFlame avatar SilentFlame commented on July 18, 2024

on it.

from flappy-svg.

SilentFlame avatar SilentFlame commented on July 18, 2024

working on the back button part.

from flappy-svg.

SilentFlame avatar SilentFlame commented on July 18, 2024

do we need to change the name of the functions?
as now it all does make sense.

from flappy-svg.

niccokunzmann avatar niccokunzmann commented on July 18, 2024

The names of the functions should describe what they do or what they stand for. You can rename them of cause. I wont judge you for long names as I am extreme on that, having functions with names of 40 characters :)

from flappy-svg.

ashutoshsaboo avatar ashutoshsaboo commented on July 18, 2024

Is this issue still open? Can I work on this?

from flappy-svg.

SilentFlame avatar SilentFlame commented on July 18, 2024

@niccokunzmann but now in the initial phase the name of the functions make sense.
On the later they don't. so what would be your suggestion if we keep the name still the same.

from flappy-svg.

niccokunzmann avatar niccokunzmann commented on July 18, 2024

@SilentFlame if it works, it is fine for me. Can you answer @ashutoshsaboo's question on what needs to be done? I just lost the overview of how far you got. Should we close the issue?

from flappy-svg.

SilentFlame avatar SilentFlame commented on July 18, 2024

@ashutoshsaboo,
I have resolved this issue.
just coming with the final PR soon.
you can review that and the last PR's to have an understanding of the issue.

from flappy-svg.

SilentFlame avatar SilentFlame commented on July 18, 2024

If satisfied with the PR, you can close this issue now. @niccokunzmann

from flappy-svg.

niccokunzmann avatar niccokunzmann commented on July 18, 2024

Ok. So after the back-button is merged, we can close it.

from flappy-svg.

niccokunzmann avatar niccokunzmann commented on July 18, 2024

Thanks @SilentFlame. Closing it!

from flappy-svg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.