Use hide and show methods for Flappy and Background about flappy-svg HOT 21 CLOSED

Leave a comment of you want to work on this issue.

from flappy-svg.

I want to work on the issue. I need some more explanation on what to do :)

from flappy-svg.

This is a code refactoring task. there are things like style.visibility=none in the code that hide and show elements. these should be replaced with the calls to the objects methods: hide() and show().

Why this is important: In the future this will allow for the hide and show methods to contain e.g. stopping an animation.

from flappy-svg.

ok i am in. i will do the task. I cannot see and style.visibility statements in the code . I am only seeings style.display. is this what you mean ?

from flappy-svg.

Yes, that is what I mean. I did not remember clearly.

from flappy-svg.

Shall i make layer as a class or just add functions in layer.js file ?

from flappy-svg.

I think, both could be ok. Go for the option which you think you would like to use and which results in understandable and usable code.

from flappy-svg.

I ll make two functions show and hide in layers.js so that any layer can use that method

from flappy-svg.

I created a pull request making necessary changes as i thought. #17

from flappy-svg.

Hi, it looks promising. I added a few comments.

from flappy-svg.

I made one more commit . Please have a look at it

from flappy-svg.

One mistake is still in: Please run the game and test it. The camel does not disappear if you click it at first, because the flappy variable is still null.
It looks very good so far, thank for cleaning up the code : )

from flappy-svg.

I am unable to see the mistake u have mentioned . can u please provide a screen cast or a screen-shots for this.
I ran it on firefox as well as chrome but didn't find any problem. Should i run them on something else ?

from flappy-svg.

You are right, I used the wrong commit - now it works perfectly. Thanks. Now, the code looks much better.

You should comment on this at Google Code-In with a link to this issue and submit it so it can be accepted.

from flappy-svg.

Also, create a new pull-request if you would like to be listed under https://github.com/fossasia/flappy-svg/blob/gh-pages/Contributors.md

from flappy-svg.

Thanks :D . Create a new pull-request with what and in which repo. i am above 17 so i can't participate in code-in :P :)

from flappy-svg.

So, the link to the task would be https://codein.withgoogle.com/tasks/5378521694208000/
And there is the file https://github.com/fossasia/flappy-svg/blob/gh-pages/Contributors.md
You can add your name and link to it if you like to. You contributed : )

from flappy-svg.

If you have ideas for new issues, they are welcome.

from flappy-svg.

I created a new pr by adding my name to contributors list. I am above 17 years so can i still participate in code-in ?
This is the pull request #18

from flappy-svg.

@harry-7 Unfortunately, No.

from flappy-svg.

Its ok . Thanks for merging my pull-request. :)

from flappy-svg.