Git Product home page Git Product logo

Comments (6)

mani87 avatar mani87 commented on June 18, 2024 1

@AshishkrGoyal can you review the changes?

from 2018.fossasia.org.

AshishkrGoyal avatar AshishkrGoyal commented on June 18, 2024 1

@mani87 your code is working fine, but actually code for this is in the file as:
https://github.com/fossasia/2018.fossasia.org/blob/master/css/custom.css
and written from 1 to 22 code lines..

so i suggest you to edit these lines and please not write CSS with HTML because we have separate CSS file for this purpose..

Thanks

@mariobehling sir your suggestion needed for this

from 2018.fossasia.org.

AshishkrGoyal avatar AshishkrGoyal commented on June 18, 2024 1

@niccokunzmann
my solution and @mani87 solution is same as i suggest @mani87 to solve it by writing external CSS code, because it is not a nice practice to write inline CSS,

@niccokunzmann the solution which was proviede by me and @mani87 is same and better than other solutions.

@vibhor98 your work is also nice but it is good practice to write external CSS.

@niccokunzmann if you will merge PR #38
then it will solve it

preview for the changes at this link:

http://ashishkrgoyal.me/2018.fossasia.org/

Thanks

from 2018.fossasia.org.

Rishabh-Kumar-Bothra avatar Rishabh-Kumar-Bothra commented on June 18, 2024

i would like to solve this issue. may i sir?

from 2018.fossasia.org.

mani87 avatar mani87 commented on June 18, 2024

@AshishkrGoyal fine now?

from 2018.fossasia.org.

niccokunzmann avatar niccokunzmann commented on June 18, 2024

@AshishkrGoyal @mani87 @vibhor98 You all presented different solutions. I would be glad if you can talk to eachother and find the one, best solution you all agree on. I hope you can learn from each other. Also, I do not want to say that I know what is best in front of you who put in most of the time and reject PRs. You all put thoughts into it, so, please share them with eachother. You can ping me with @niccokunzmann, if you like.

from 2018.fossasia.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.