Bug: Set compares by reference not value about react-fast-compare HOT 6 OPEN

Looking at the solution comment on the related issue linked by @ryan-roemer above ^, it appears we can solve this issue by requiring fast-deep-equal/es6 instead of fast-deep-equal.

Is this something we would be willing to change? It seems like there are going to be larger implications updating this dependency, but I don't know that I can immediately identify what they'll be.

cc @chrisbolin

from react-fast-compare.

Now tracked upstream with a potential bugfix: epoberezkin/fast-deep-equal#50

from react-fast-compare.

good catch, @kale-stew! I say we don't take it on yet, but that's a path we could go down

from react-fast-compare.

@chrisbolin @kale-stew -- Upstream FDE AFAICT incorrectly closed the issue. Their current master https://github.com/epoberezkin/fast-deep-equal/blob/master/src/index.jst#L34-L39 still does reference comparison and does not do a recursive equality check as my POC experiment code above does.

from react-fast-compare.

And as our general note our source already tracks fast-deep-equal/es6 😉

from react-fast-compare.

Do we have to way for fast-deep-equal/es6 to fix this before it can be fixed in this repo?

from react-fast-compare.