Git Product home page Git Product logo

Comments (8)

ppessi avatar ppessi commented on May 30, 2024 1

Working on it. What maximum line length do you want? Some variables and strings are very long and hard to fit.

from octolapse.

FormerLurker avatar FormerLurker commented on May 30, 2024

100, 120 maybe something around there? My IDE wraps pretty nicely, and I have a big enough display that I didn't notice. Honestly I'm SO appreciative of any help here that I'm more than willing to let you do what you want. I just sort of started coding without knowing anything about python, and that will probably be pretty apparent. I have been spoiled by safe, project wide refactoring...

Could you please pull from the BetaDevelopment branch? Shadowen and I have been working on that branch, and will continue to until the next beta version is released, which should be a few days at least.

Lastly, I think many smaller commits would be best, too, since so much of the code will be touched. What do you think?

Thanks again ppessi!

from octolapse.

Shadowen avatar Shadowen commented on May 30, 2024

I'm using whatever my IDE autoformats to. I basically autoformat every time I save... I think PyCharm will obey .editorconfig though, so just keep that updated with whatever guidelines you choose.

from octolapse.

Shadowen avatar Shadowen commented on May 30, 2024

Might want to change the Python setup:

[**.py]
indent_style = tab

Spaces are preferred.

from octolapse.

FormerLurker avatar FormerLurker commented on May 30, 2024

I believe I have fixed the build issues. Sorry if my fixes messed up some of your style changes, I'm having trouble preventing my IDE from making changes. Now that the build is working again I'll whip my IDE into shape.

I'm going to leave this issue open since I still want to take a look at the naming conventions functions/variables.

Things are starting to look a lot better, thanks again!

from octolapse.

ppessi avatar ppessi commented on May 30, 2024

You're welcome :) I'm glad to help

from octolapse.

FormerLurker avatar FormerLurker commented on May 30, 2024

Just a few minor issues to take care of in the .py files. Pretty much only the files in \test need to be refactored.

from octolapse.

FormerLurker avatar FormerLurker commented on May 30, 2024

There are a few issues still, but to the best of my knowledge our .py files comply with PEP8!

Thanks to everyone who contributed to this issue. It was a huge task and I'm so glad I had help. I think this will make it easier for new people to contribute and read the code. Well, without as gagging as much, lol!

I declare this issue CLOSED!

from octolapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.