doesn't support submitting to a url that requires basic auth about form-data HOT 4 CLOSED

Thank you, good catch. :)
Let me sleep on it.

from form-data.

Now (#22) you can specify custom parameters for form.submit() with auth or any other parameter supported by http.request() or https.request()
Please refer to the Readme for example.

Thank you.

from form-data.

Custom parameters are cool, but I don't think your commit fixes the initial bug I reported - just adds a workaround.

If you pass in just a url to form submit, with the basic auth encoded in the url (e.g. http://username:[email protected]/path), you're still throwing away the field returned from urlParse. This is on line 251 (https://github.com/alexindigo/node-form-data/blob/4581140f322758c6fc92019d342c7d7d6c94af5c/lib/form_data.js#L251)

so form.submit('http://username:[email protected]/path') would still not work but, as a workaround, you could do form.submit({host: 'host.com', path: '/path', auth: 'username:password', protocol: 'http:'})

I think a simple fix is just changing line 251 to instead be options = populate(params, defaults) and then you're not throwing away params.auth

from form-data.

I don't want to screw up implementations that already out in the wild,
so to be on a safe side we'll keep original 'simple' interface intact,
and for everything else not so mainstream we'll have extended interface.

By the way, http is default protocol, so you can safely omit it.

form.submit({host: 'host.com', path: '/path', auth: 'username:password'})

And you can do something like that:

form.submit(parseUrl('http://username:[email protected]/path'))

Although former example looks more appealing to my taste.

from form-data.