Comments (7)
The fix has been release in the 1.1.5 liana version. Here are the changelogs.
from forest-express-mongoose.
Hi @gunar, validation is not something the current liana manage properly.
We definitely want to improve this, in the future releases.
As you may notice, we have a PRΒ in review to support simple validations here: #35
But you seem to have complex validations. We would love to have a small example of your complex validation to help us implement it.
π²π²π²
from forest-express-mongoose.
Hi @arnaudbesnier
Thanks for the quick response
Why it is needed to implement code for validation?
If you take my model and do instance.save()
it will throw, in case of validation errors
Isn't that what forest-express-mongoose
does?
from forest-express-mongoose.
@gunar sorry for the misunderstanding... The PR I showed you is a feature to improve the validation experience.
You are right, as the liana is based on the Mongoose ORM. It means that the validations you defined in your models should work while using Forest.
If I understand well, you are submitting an issue here, right?
Your custom validations are simply not executed or do you notice another unexpected behaviour?
Can you provide a simple code example based on your code, that we could use to reproduce the issue?
from forest-express-mongoose.
Thank you for the feedback
Here's the code https://github.com/gunar/forestRepro
Validators are not being checked on updates (only on inserts, it seems)
Validator on insert works
Create
bitcoin.code = 'ZZZ'
Then try to create
litecoin.code = 'ZZZ'
I get a validation error
Validator on update does not work
Create
bitcoin.code = 'ZZZ'
litecoin.code = 'ZZA'
Then update
litecoin.code = 'ZZZ'
I get no validation error, but should have
from forest-express-mongoose.
@gunar Ok I think I found the reason why the validations are not triggered on record update. I think the method findByIdAndUpdate
(https://github.com/ForestAdmin/forest-express-mongoose/blob/devel/services/resource-updater.js#L19) needs to have the runValidators
option set to true
which is not the case.
Let me reproduce and fix this week.
from forest-express-mongoose.
@gunar can you check if the PR fixes your issue?
from forest-express-mongoose.
Related Issues (20)
- TypeError: Class constructor ObjectId cannot be invoked without 'new' HOT 4
- export ResourceSerializer in type definition
- Forest Admin UI incorrectly display nested field HOT 2
- Smart Ations fields hooks endpoint cannot authenticate HOT 5
- Is this still supported? HOT 2
- Update document example from documentation doesn't seem to work HOT 1
- TypeError: RecordsRemover is not a constructor HOT 3
- Forest Admin Dashboard display mongoose mixed data type as [object,object]
- Forestadmin with Typescript project and MongoDB Atlas Free Plan
- Should be able to specify location of .forestadmin-schema.json HOT 1
- Non-Date types that store Date values cannot be rendered as a time-based Chart HOT 1
- Nested Enum types do not have values in the schema and crash the Create page in the UI HOT 7
- Smart relationship does not query the route HOT 4
- Smart actions - primaryKeys not generated in forestadmin schema HOT 2
- Smart Relationships are all empty in 7.8.4 and after
- Weird behaviour with certain model names HOT 1
- Having trouble connecting HOT 2
- Impossible to delete values in array field
- Can't user react components for smart views
- Vulnerability Notice on moment-timezone. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forest-express-mongoose.