After updating Fody debugging is no longer possible about fody HOT 15 CLOSED

#1102 seems to be the only relevant change in this release, so this might be related to Cecil.

from fody.

@ltrzesniewski @SimonCropp Can anyone reproduce this? I got this in several projects.

Seems like these are the only changes related to .pdb:
jbevain/cecil@79b43e8
jbevain/cecil@8b593d5
@vitek-karas any idea why this is now broken?

from fody.

After changing DebugType to portable it works again. @vitek-karas @jbevain maybe the latest changes regarding pdb writing are not applicable when using embedded pdbs?

from fody.

@tom-englert i hvant noticed. do u want me to revert for now and re-deploy?

from fody.

The issue doesn't reproduce under Rider 2022.2 EAP 4 (after updating Fody to v6.6.2 in your project).

I can repro this is VS though.

from fody.

In the unit tests we use System.Reflection.PortableExecutable.PEReader, that seems to have also no problem.

from fody.

Should we revert then? And is this a bug of VS or Cecil?

from fody.

6.6.3 deployed

from fody.

Sorry for the late reply on this. I'm busy with other things, so didn't have a chance to spend too much time on this. I can repro it with the project provided by @tom-englert (thanks!). But it seems that it's not a wide-spread problem. For example the dotnet/linker uses Cecil to read->write assemblies as well and using an embedded PDB I could not repro the problem there.
So it's either something special about some code pattern, or it's something special about Fody's usage of Cecil.

from fody.

@vitek-karas it's not specific to Fody:

jbevain/cecil#856

from fody.

I'm using Fody 6.6.4 and debug is still broken for me. Removing Fody package allows the app to be debugged again.

Quote from the link below

So our target _CollectPdbFiles is not finding the myMowasat.Android.pdb in the bin/Debug/ directory. This is why it is not being deployed.
Looking a the log in more detail and it seems that Fody.targets is reassigning the DebugType property from portable to embedded.
https://github.com/Fody/Fody/blob/master/FodyHelpers/build/FodyHelpers.props#L4
I'm not sure why its doing that but it might stop our debugger from working. I'm not sure the mono soft debugger works with embedded symbols afaik.
Are you using Fody for anything? If not it might be worth removing the package reference if you are not really using it.

https://developercommunity.visualstudio.com/t/Unable-to-debug-Android-app/10220577#T-ND10226714

from fody.

@mohibsheth with which version did it stop?

from fody.

Not sure but in our project, previously it was 4.0.2 and I recently upgraded it directly to 6.6.4

Removing FodyHelpers NuGet fixes my debug issue.

from fody.

Removing FodyHelpers NuGet fixes my debug issue.

You are not supposed to reference the FodyHelpers package, unless you are developing a Fody weaver. If you want to use Fody, you should reference the Fody package + the weavers you need.

from fody.

Ah ok, thanks for the clarification. As I mentioned above, the project is quite old and I was upgrading everything to the latest. I guess in older versions FodyHelpers nuget was also required but now it's not.

Thanks.

from fody.