Git Product home page Git Product logo

Comments (12)

genofire avatar genofire commented on May 10, 2024 1

Sounds nice - i really do not like this code: code snipped from thrempp

from go-xmpp.

mremond avatar mremond commented on May 10, 2024 1

Here is what the code looks like for Message extension: 4a4c485

I will now expand Presence to have []PresExtension and implement a similar Get method.

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

Thanks for the pointer, I will have a look.
Let's try to make it possible for you to use the same underlying client for all your code base :)

from go-xmpp.

genofire avatar genofire commented on May 10, 2024

FYI there are:

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

The main advantage of extensions is that they are extensible by the developer. You can use the lib and use your custom namespace extension.

We could have a getter for extensions, a bit similar to your nil test, that could look like (peudo-code):

	var muc MUC
	if ok := p.Get(&MUC); ok {
		// Handle MUC
	}

Anyway, I am still torn between simplicity of your approach and trying to build something that is a bit more complex but could handle more developers' needs ...

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

Ok thanks for feedback, I will try to prepare something as discussed during the week-end :)

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

I now think that oob and MUC presence extension should be ok for your needs.
I created #68 to track the development of XHTML extension support on messages.

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

@genofire I have added basic HTML support (see #69). You should have everything to port your code hopefully.
Please, open new issue if you think we are still missing important features.

from go-xmpp.

genofire avatar genofire commented on May 10, 2024

#69 is for MUC not HTML

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

Oups, sorry, it is #70

from go-xmpp.

genofire avatar genofire commented on May 10, 2024

Supi - now i need time to migrate by Programms ;)

Thank you for developing and maintaining xmpp library, it is really useful

from go-xmpp.

mremond avatar mremond commented on May 10, 2024

Thanks for your feedback and your help :)

And no rush / no pressure to upgrade your programs, I have plenty to do as well.

from go-xmpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.