Git Product home page Git Product logo

Comments (5)

escamoteur avatar escamoteur commented on July 23, 2024 2

Implemented in V7.6.8

from get_it.

escamoteur avatar escamoteur commented on July 23, 2024

why not just registering in setup?

from get_it.

feinstein avatar feinstein commented on July 23, 2024

Also ignoreReassignment could be marked as @visibleForTesting.

why not just registering in setup?

I have a setup function the runs at the beginning, but I want to reassign one of the singletons being created there. The only way I have is verbose, I need to pass nullable instances to setup, so I can verify if they are null or not. If they are not null, I use them, so this is how we can inject fake instances for tests. This very verbose and could be immensely simplified if we had a ignoreReassignmentForTesting.

Here's an example of what I have to do now:

@override
  Future<void> setup({
    Dio? dio,
    ExampleRestDataSource? exampleRestDataSource,
    PackageInfo? packageInfo,
    ExampleRepository? ExampleRepository,
    ExampleCubit? ExampleCubit,
  }) async {
    getIt
      ..registerSingleton(dio ?? Dio())
      ..registerSingleton(exampleRestDataSource ?? ExampleRestDataSource(getIt()))
      ..registerSingleton(packageInfo ?? await PackageInfo.fromPlatform())
      ..registerSingleton(exampleRepository ??
          ExampleRepository(
            exampleRestDataSource: getIt(),
            packageInfo: getIt(),
          ))
      ..registerSingleton(exampleCubit ?? ExampleCubit(exampleRepository: getIt()));
  }

from get_it.

dmrickey avatar dmrickey commented on July 23, 2024

why not just registering in setup?

Because that yields the same result as what I outlined above. If I moveGetIt.I.registerSingleton<IFoo>(FakeFoo()); into setup, the test is still going to blow up when I call app.startup because startup registers RealFoo. Right now we have to have suboptimal code in our production code so that we can conditionally register dependencies based on whether we're testing or not.

from get_it.

escamoteur avatar escamoteur commented on July 23, 2024

OK, I think I finally understood this issue the first time, my bad. We probably should call the option something like skipDoubleRegistrations

from get_it.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.