Git Product home page Git Product logo

Comments (5)

lebow01 avatar lebow01 commented on May 27, 2024

How do I adjust the AspectRatio in full screen?

from chewie.

lebow01 avatar lebow01 commented on May 27, 2024

Video will distort when full screen.

from chewie.

patrickbz avatar patrickbz commented on May 27, 2024

I changed this in lib/src/player_with_controls.dart:

@@ -48,7 +48,10 @@
width: MediaQuery.of(context).size.width,
child: widget.fullScreen &&
MediaQuery.of(context).orientation == Orientation.landscape
- ? _buildPlayerWithControls(controller, context)
+ ? new AspectRatio(
+ aspectRatio: widget.aspectRatio,
+ child: _buildPlayerWithControls(controller, context),
+ )
: new AspectRatio(
aspectRatio: widget.aspectRatio,
child: _buildPlayerWithControls(controller, context),

@@ -69,7 +72,10 @@
child: widget.fullScreen &&
MediaQuery.of(context).orientation ==
Orientation.landscape
- ? new VideoPlayer(controller)
+ ? new AspectRatio(
+ aspectRatio: widget.aspectRatio,
+ child: new VideoPlayer(controller),
+ )
: new AspectRatio(
aspectRatio: widget.aspectRatio,
child: new VideoPlayer(controller),

and it seems working with correct aspect ratio also in fullscreen. I only specify the aspect ratio in Chewie with aspectRatio.

from chewie.

Sub6Resources avatar Sub6Resources commented on May 27, 2024

Go ahead and open a pull request with your changes and we'll do some more testing to make sure we don't get any unexpected results.

from chewie.

brianegan avatar brianegan commented on May 27, 2024

Published as part of 0.8.0. Thanks again!

from chewie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.