Allow serving compresses responses via Prometheus plugin about fluentd HOT 10 CLOSED

Oh yah
i missed this infact. Thanks for pointing it. I will try to check this in my free time.

from fluentd.

Maybe can close this one, since it was implemented on the plugin itself, and I also filed an issue there

fluent/fluent-plugin-prometheus#219

from fluentd.

@Lusitaniae I have one query with this. I understand you want to expose it in compressed format but can you name few metrics collectors that scrape in compressed format and decompresses it?
I have worked with Telegraf and chronocollector and both don't support scraping metrics that are in compressed format

I guess if this is not the standard then not sure if its a genuine feature request

from fluentd.

Should work for prometheus

https://github.com/prometheus/prometheus/blob/main/scrape/scrape.go#L729

https://prometheus.io/docs/instrumenting/exposition_formats/

from fluentd.

I see
For now it seems only gzip format is supported
Maybe I can pick this up in the following week

from fluentd.

Much appreciated 🙏

from fluentd.

@Lusitaniae This would require to contribute to https://github.com/prometheus/client_ruby/blob/main/lib/prometheus/client/formats/text.rb the official prometheus client for ruby. The hackaround for this is we break the abstractions in the Fluentd prometheus plugin to fetch the metrics info and compress and host directly. Not sure which is a better call because maybe first is overkill but I feel that's the write method

from fluentd.

Doesn't this solve it?

It's highly recommended to enable gzip compression for the metrics endpoint, for example by including the Rack::Deflater middleware.

https://github.com/prometheus/client_ruby?tab=readme-ov-file#rack-middleware

from fluentd.

I was checking this @Lusitaniae. So for the Rack middleware to be used we need to have the app(http server) exposed and get overriden with the middleware. But i guess the code abstraction in fluentd has made use of a plugin helper so seems like its not as direct as we see. I am actively checking how to make use of it but incase if you also find something interesting please let me know

For now i am not using rack but trying to compress the data directly and put it in the response body

from fluentd.

@kenhys the PR is done for this and reviewed by @ashie. I guess u can change the label to the appropriate one
fluent/fluent-plugin-prometheus#223

from fluentd.