Support Node.js v4 plan about fluent-logger-node HOT 14 CLOSED

Additional information.

msgpack5 is too slow, so I want to revert msgpack5 related changes.

See http://yukidarake.hateblo.jp/entry/2015/08/10/194319 (Written in Japanese)

from fluent-logger-node.

thanks for raising this topic.

How complex is to port to the new library ?

from fluent-logger-node.

It is very easy to support msgpack-1.0.2.
Just revert msgpack5 related changes in 6f2a3f6 and adjust package.json.

I have patches in my laptop and I will work for this in next week.

from fluent-logger-node.

that would be great. I'd definitely support this change.

from fluent-logger-node.

In fluent-logger-node, we use only encoding.
Could you check only pack/encode performance?
If msgpack5 is too slow, vote for changing to msgpack.

from fluent-logger-node.

Check performance.
https://gist.github.com/okkez/2b77b32ad3a966446347

msgpack is faster than msgpack5.

$ node benchmark.js
msgpack5: 856ms
msgpack: 29ms

from fluent-logger-node.

I see. One concern is msgpack5 has extension type support.
Does msgpack have this feature?

from fluent-logger-node.

FYI: kawanet/msgpack-lite

msgpack-lite is faster than msgpack.
msgpack-lite supports extension type.

from fluent-logger-node.

Update benchmark script and result.
https://gist.github.com/okkez/2b77b32ad3a966446347

$ node ./benchmark.js
msgpack5: 821ms
msgpack: 36ms
msgpack-lite: 23ms

from fluent-logger-node.

Does msgpack have this feature?

Maybe msgpack does not support extension type feature.
I've checked JavaScript APIs and README.md.

from fluent-logger-node.

I've created branch https://github.com/okkez/fluent-logger-node/tree/use-msgpack-lite
It is very easy to change back end library to process msgpack.
Pass all tests with msgpack-lite for now.

How about msgpack-lite for fluent-logger-node?
If we use msgpack-lite, we can support all node versions in master branch for now.

from fluent-logger-node.

👍 > msgpack-lite

from fluent-logger-node.

I've released new version 0.4.1 using msgpack-lite.

from fluent-logger-node.

😃

from fluent-logger-node.