Comments (7)
Some more info: this problem fit 'git bisect' really well, since checking the window's w() value could be done after the resize() to detect the failure condition, without ever needing to open the GUI.
It zeroed in on this commit:
c66caf5dce9331fd3e011873711a768adb28cf9d is the first bad commit
commit c66caf5dce9331fd3e011873711a768adb28cf9d
Author: ManoloFLTK <[email protected]>
Date: Sun Apr 7 09:09:33 2019 +0200
Simpler implementation of Fl_Cocoa_Window_Driver::resize()
from fltk.
Oh, and for what it's worth, here's the bisect operation that was done:
1. Modified the resize.cpp program, adding this one line above Fl::run() to detect the error:
if ( window->w() == 25 ) exit(1); else exit(0); // exit(1)=FAIL, exit(0)=OK
2. Created a script called 'bisector' in the fltk directory with the contents:
#!/bin/sh
make clean && ( cd src ; make -j 4 ) && ( cd test ; ../fltk-config --compile resize.cpp )
test/resize
exit $?
3. Ran git bisect with the start/end commits from the fltk main directory using:
git bisect good 6838814f9e6433fc93ff73f4415fe30bbd7ed326
git bisect bad 23484c30a9126dcda3f589cd63e3fe2ec8b41c98
git bisect run ./bisector
from fltk.
That should be fixed now.
from fltk.
Great, the window size is fixed.
But there's still maybe a problem: if I scale the test program with e.g. Cloverleaf(+), the window contents disappears.
(I noticed this same issue when I tried applying my own fixes, so I knew to check for it)
from fltk.
That should be "really" fixed now.
from fltk.
Confirmed!
The combination of commit d068fbf and commit 83bd04e solved the issue, thanks Manolo.
from fltk.
FTR: the mention above in issue 427 is irrelevant (unintended).
from fltk.
Related Issues (20)
- #96bacd3 may crash on X11 HOT 6
- Fl_Input pop menu customize doesn't work HOT 3
- memory leak in howto-menu-with-images.cxx HOT 12
- Fl_Plugin_Manager::loadAll doesn't work correct HOT 2
- `FL_SHORTCUT` and `FL_KEYBOARD` do not honor `FL_WHEN_RELEASE` for `FL_RADIO_BUTTON` HOT 15
- Wayland + full-size subwindow resizing issue HOT 9
- Fl_Text_Editor prevents scrolling parent Fl_Scroll HOT 15
- When zooming window, the window size range must be adjusted HOT 3
- Wayland: numeric keypad keys don't work as intended when NumLock is off HOT 8
- Fl_Terminal has some issues with tabs if it is created with 0 size HOT 2
- zenity fails to start when file chooser's path has an apostrophe HOT 16
- Text selection with keyboard in Fl_Text_Editor stops working when left clicking inside selection HOT 4
- Fl_String is missing != test HOT 1
- Crash after release of shared image (regression) HOT 17
- Warning in build of most recent Fl_Shared_Image.cxx HOT 1
- Fl_Button.cxx::handle() has no explicit return for switch case FL_KEYUP HOT 1
- Invisible mouse cursor when activating menu with the keyboard HOT 2
- Crash in Fl_Preferences if file has bad format HOT 13
- Wayland: crash with set_menu_window() HOT 6
- Wrong tooltip position on Wayland with secondary monitor HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fltk.