Git Product home page Git Product logo

Comments (7)

erco77 avatar erco77 commented on June 30, 2024

Some more info: this problem fit 'git bisect' really well, since checking the window's w() value could be done after the resize() to detect the failure condition, without ever needing to open the GUI.
It zeroed in on this commit:

c66caf5dce9331fd3e011873711a768adb28cf9d is the first bad commit
commit c66caf5dce9331fd3e011873711a768adb28cf9d
Author: ManoloFLTK <[email protected]>
Date:   Sun Apr 7 09:09:33 2019 +0200

    Simpler implementation of Fl_Cocoa_Window_Driver::resize()

from fltk.

erco77 avatar erco77 commented on June 30, 2024

Oh, and for what it's worth, here's the bisect operation that was done:

1. Modified the resize.cpp program, adding this one line above Fl::run() to detect the error:

    if ( window->w() == 25 ) exit(1); else exit(0); // exit(1)=FAIL, exit(0)=OK

2. Created a script called 'bisector' in the fltk directory with the contents:

      #!/bin/sh
      make clean && ( cd src ; make -j 4 ) && ( cd test ; ../fltk-config --compile resize.cpp )
      test/resize
      exit $?

3. Ran git bisect with the start/end commits from the fltk main directory using:
      git bisect good 6838814f9e6433fc93ff73f4415fe30bbd7ed326
      git bisect bad 23484c30a9126dcda3f589cd63e3fe2ec8b41c98
      git bisect run ./bisector

from fltk.

ManoloFLTK avatar ManoloFLTK commented on June 30, 2024

That should be fixed now.

from fltk.

erco77 avatar erco77 commented on June 30, 2024

Great, the window size is fixed.
But there's still maybe a problem: if I scale the test program with e.g. Cloverleaf(+), the window contents disappears.
(I noticed this same issue when I tried applying my own fixes, so I knew to check for it)

from fltk.

ManoloFLTK avatar ManoloFLTK commented on June 30, 2024

That should be "really" fixed now.

from fltk.

erco77 avatar erco77 commented on June 30, 2024

Confirmed!
The combination of commit d068fbf and commit 83bd04e solved the issue, thanks Manolo.

from fltk.

Albrecht-S avatar Albrecht-S commented on June 30, 2024

FTR: the mention above in issue 427 is irrelevant (unintended).

from fltk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.