Git Product home page Git Product logo

Comments (6)

HenryHengZJ avatar HenryHengZJ commented on June 7, 2024

You are right. We still don't yet implement a solution to just upsert the delta changes, everything will be re-upsert again. This is the area we need to improve. We can implement a logic to compare the new embeddings to the cached embeddings, and upsert the new ones. Since we already have embeddings caching:

image

from flowise.

niztal avatar niztal commented on June 7, 2024

@HenryHengZJ

Thank you very much for the honest response,

Do you have any estimation for the fix you were proposing?

By the way I read over pinecone's documentation they do support upsert, why not use their API I think they should handle the logic of upset once it exists and not flowise

https://docs.pinecone.io/reference/upsert

Thanks

from flowise.

HenryHengZJ avatar HenryHengZJ commented on June 7, 2024

we are using the upsert API under the hood via langchain abstraction. however the ids are different each time you upsert, that causes duplication.

dont have any estimation, but its one of the higher priority item we are taking a look at

from flowise.

niztal avatar niztal commented on June 7, 2024

Thanks for your honesty @HenryHengZJ

One last question please

Untill you'll fix this issue, if I'll reinsert the same vectors over and over again, is that something which may effect the performance or the accuracy of my bot?

Thanks

from flowise.

niztal avatar niztal commented on June 7, 2024

seems like it is a very hard task to achieve, I recommend not using upsert, but rather do delete all documents and re-insert these. @HenryHengZJ

from flowise.

e-lobo avatar e-lobo commented on June 7, 2024

soupsert cannot be used? im also noticing duplicates in my vector store. @HenryHengZJ your solution to use redis did not work

from flowise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.