Ditch the Connection Re-established popup! about node-red-dashboard HOT 13 CLOSED

Cnnfiguration option on the ui-base seems an easy middle ground here. Default should be "on" in my opinion.

from node-red-dashboard.

If I may interject, perhaps making notification configurable, allowing en/disabling and setting of notification dismiss delay, would be a better approach here. I myself and @Paul-Reed, if I recall correctly, in addition to the maintainers I’d assume, find it useful.

from node-red-dashboard.

I'm happy to add this as an example in the "Template Examples" docs, but I'm not sure I can be convinced of this being the default., or as part of core, as it would interfere with any app-bar-actions that users define.

from node-red-dashboard.

I myself and @Paul-Reed, if I recall correctly, in addition to the maintainers I’d assume, find it useful.

In what way do you find it useful? I can see that during debugging that may have been the case, but once the comms failure notification is working correctly then the fact that the failure popup is not there means that the connection must have been restored. There is no such indication in Dashboard 1, the fact that the Connection Failed message is not shown indicates that all is well.

from node-red-dashboard.

the fact that the Connection Failed message is not shown indicates that all is well.

Good point. Notifications should logically appear as a result of an exception, in this case communication failure. That said, reconnection notification would seem more appropriate in a debugging capacity.

I do however enjoy regularly being able to see a visual indicator that my data is live, but something less intrusive like a green/red circle at top right of header could suffice.

That’s my perspective on the issue, but the final decision rests with the maintainers.

from node-red-dashboard.

That sounds like a plan :)

from node-red-dashboard.

Any thoughts on an always present circular status indicator in top right corner as an optional alternative to the notifications? Something like the one I'm using below:

from node-red-dashboard.

Ah yes, it would definitely interfere.

But what about something smaller like this? But choice is totally up to you.

from node-red-dashboard.

@cgjgh I guess the point is that given the top right side of the bar is completely configurable , it is not advisable to have anything in there at all whether small or large - for example we have custom toolbar actions extensions in there.. having said that I am also not a big fan of popup notifications at all and in fact wish we ditch any sort of popup notifications everywhere unless absolutely necessary to convey a critical state that requires user intervention or alert

from node-red-dashboard.

I agree with @nileio about not having the dot in the title bar as it would frustrate users who wanted to later personalize it.
But happy with the pop up, and as Joe suggested - making it a ui- base option.

from node-red-dashboard.

I still don't see the need for a 'reconnected' popup. D1 does not have one, the connection lost message just disappears, and I don't remember anyone ever asking for it.

from node-red-dashboard.

Not sure if anyone else has had this problem, but I’ve quite often had times where even though Dashboard was disconnected the alert didn’t show which was my reason for wanting an always present indicator. On any socket connect or disconnect event it sets a connected variable which indicator is mapped to. This has proved much more reliable than the alert, with indicator being correct 100% of the time.

But just testing the waters here, if no one else has this issue then it’s definitely not necessary to add it.

from node-red-dashboard.

I have not seen that issue. Since the disconnected was introduced then it seems to have been reliable.

from node-red-dashboard.