Comments (9)
The same issue happens in Chrome when you directly open encrypted thread in encrypted inbox
:
- open
encrypted inbox
- open encrypted thread - messages successfully decrypted
- reload thread page - messages stuck in
loading...
state
@ioanmo226 let's work on this issue next, so we'll be able to publish new Firefox release, as this bug makes it impossible to use extension in Firefox
from flowcrypt-browser.
You mean in gmail page or in extension page?
from flowcrypt-browser.
On gmail page, it stucks in this state for me:
![Screenshot 2024-06-21 at 15 26 50](https://private-user-images.githubusercontent.com/1062093/341761557-40a13252-348d-492d-8881-5b5c8967bc7b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM3MDAxNTEsIm5iZiI6MTcyMzY5OTg1MSwicGF0aCI6Ii8xMDYyMDkzLzM0MTc2MTU1Ny00MGExMzI1Mi0zNDhkLTQ5MmQtODg4MS01YjVjODk2N2JjN2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTVUMDUzMDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjQ3NjUwYWI3NmY4NzkyNjE4MjM5MTgzYmU1YTk1MzA0MGU5OWU2YjJkMzJkNWI4YjVmZGU0YjExNmM2NTNhZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.zDuTZ0ANnRwaoLotHR3JJWQvUcYbH81hx3Hr8b92z9g)
Can you reproduce this issue?
from flowcrypt-browser.
Couldn't reproduce issue in gmail page but can reproduce in extension page
from flowcrypt-browser.
Anyway, There's indeed an issue for firefox
from flowcrypt-browser.
I've taken a detailed look at this issue and I think it warrants a brainstorming session. Currently, both the GmailElementReplacer
(content script) and InboxView
use messageRenderer
to download and process messages.
Once the PGP block is ready, we attempt to render it. However, the problem is that the PGP block remains stuck in a loading
state when loaded by itself because there's no message rendering mechanism within the PGP block frame. It heavily relies on GmailElementReplacer
when loaded on a Gmail page with a content script, and on InboxView
when the user accesses the extension inbox page and opens individual PGP block views.
So, I think we should implement a message rendering logic in the PGP block frame as well. The downside is that the message rendering logic will be duplicated (in both the PGP block frame and GmailElementReplacer
/InboxView
).
What are your thoughts on this?
from flowcrypt-browser.
But it works well in Chrome - I haven't noticed similar issue there. My assumption was that BrowserMsg.send
fails in some cases on Firefox, so pgpBlockReady
event isn't received by pgp block and causes its stuck in loading...
state.
I'll send you video of this issue by email.
So, I think we should implement a message rendering logic in the PGP block frame as well. The downside is that the message rendering logic will be duplicated (in both the PGP block frame and GmailElementReplacer/InboxView).
As I remember, previously we've had such duplicated logic, and last year moved it to MessageRenderer
, it'll be better to keep it there in a single place.
from flowcrypt-browser.
But in chrome, message decryption (in extension inbox page ../inbox.htm?threadId=${threadId}..
)doesn't work well when there are multiple messages in thread. (one of message decryption doesn't work and it is stuck at loading)
let me have a deep look.
from flowcrypt-browser.
It's strange, but mentioned issue doesn't occur for me anymore - I opened encrypted thread, waited 30-40 seconds until loading...
label disappeared and error message appeared - Cannot get reply data for the message you are replying to.
, which means that fetchReplyMeta request failed.
I tried to add some logs for finding original error, but since then message loading doesn't stuck - works well on gmail page and in encrypted inbox.
from flowcrypt-browser.
Related Issues (20)
- refactor content scripts to make it easier to implement Thunderbird support HOT 3
- Update web-ext to v8 HOT 1
- Error when trying to send exception from content script
- Attachments are not decrypted in Gmail offline mode HOT 8
- acctEmail is not included when redirecting user to compatibility checker page
- Firefox manifest.json includes background.service_worker as a manifest version 2
- Add test for the FlowCrypt for Thunderbird implementation HOT 3
- MIME type parsing for Thunderbird extension build
- Use appropriate Namespace/Typings for Firefox build
- [URGENT] FlowCrypt browser extension signin is blocked HOT 18
- Reduce items on GlobalStore.get(['account_emails']) when users perform reset (logout)
- if special JWT is stored in local store, it should be used for Enterprise Server authentication instead of Google JWT
- we should differentiate `GoogleAuthErr` and `EnterpriseServerAuthErr`. When custom IdP is used and it is `EnterpriseServerAuthErr`, we should be showing `ConfiguredIdpOauth` popup instead of `GoogleOAuth` popup HOT 12
- missing key management features? HOT 1
- Unstable tests in Semaphoreci HOT 1
- Live tests fail after https://github.com/FlowCrypt/flowcrypt-browser/pull/5795
- Sending feedback to /shared-tenant-fes/api/v1/account/feedback should be encrypted by a reciever's public key HOT 4
- [Feature Suggestion] Ability to generate keys within the extension HOT 1
- [Feature Suggestion] Ability to manage any backups from Gmail HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flowcrypt-browser.