Which interfaces are already written? about flow-typed HOT 7 CLOSED

Thanks @marudor!

This set of PRs has been really helpful in fleshing out the process of review. Here are some thoughts so far:

Reviewing Test Files

• Every definition file should have at least one test_ file that exercises it.
• Each def file should be tested in at least the following ways
  1. Import all declared modules (make sure the act of merely using a libdef doesn't cause flow errors)
  2. Verify that all globals expected to be declared are visible in the test file
  3. Include both positive and negative tests to ensure that type checking is actually happening (AKA: Use // $ExpectError in at least a few places to ensure that we're getting type errors in a few critical places we would expect them)
  4. Include type assertions about at least a few items declared by the definition file (i.e. positive test: (new Widget().install(): void); and negative test: // $ExpectError \n (new Widget().install(): number)

Reviewing Library Definitions

• I've been looking closely at the docs for the library being defined and comparing that with the libdef
• In general definitions should avoid using any types (which also includes Function and Object) unless strictly necessary. In many places, using mixed in place of any in definition files will work and is a bit safer because it means that if the type ever leaks out of the definition somehow, it will need to be explicitly refined by the user before it can be used. I've opened #49 to track adding a feature to validate-defs that comments on a PR when it introduces an any type explaining that this should be avoided if at all possible. We don't want to ban any types completely (sometimes they are strictly necessary), only discourage their use if there is an alternative.

I think that's all the patterns/thoughts I've noticed so far, so let's add more here as things progress and eventually put them into the readme!

from flow-typed.

Good idea, @chrisbolin. Thanks for posting those!

I'll link another one in here, the immutable.js definitions that are in progress:
immutable-js/immutable-js#203

Specifically, this one by @halletj
immutable-js/immutable-js#203

from flow-typed.

I think it would be also a good idea too move/copy the react definitions from the flow repository itself to here. Although a lot of people probably rely on them currently, so there should be some strategy on how to clever move them without breaking flow for a large group of people. Maybe a deprecation warning if one uses the react definitions from flow itself and how a short message to migrate to this repository.

from flow-typed.

FWIW: I think it would be great to start pulling these libdefs in now.

Most of the remaining work on flow-typed is related to building out the CLI to make it easier to acquire the libdefs -- but seeding the repo (and having a nicely central place for people to come and find them manually) would still be very useful.

from flow-typed.

+1, especially @marudor if you have time.

from flow-typed.

As you can see by the PRs I've put my libdefs in here. Now it's time to review them.

from flow-typed.

I close this issue, since there is an established process and a list of definitions now :-)

from flow-typed.