Git Product home page Git Product logo

Comments (2)

FlorianRappl avatar FlorianRappl commented on June 29, 2024

Hi @Lecrapouille - great catch!

Do you mind making a PR? Would be much appreciated! Thanks 👍

from cmdparser.

Lecrapouille avatar Lecrapouille commented on June 29, 2024

How do you want I fix it ? I do not know well this library and therefore I'm not sure to clearly understand what the code does. They are several solutions:

  1. Is print_value() is supposed to return stringify(value); instead of return "" ? And what initial value shall I set to value ?
		template<typename T>
		class CmdFunction final : public CmdBase {
		public:
			explicit CmdFunction(const std::string& name, const std::string& alternative, const std::string& description, bool required, bool dominant) :
				CmdBase(name, alternative, description, required, dominant, ArgumentCountChecker<T>::Variadic) {
			}

			virtual bool parse(std::ostream& output, std::ostream& error) {
				try {
					CallbackArgs args { arguments, output, error };
					value = callback(args);
					emptyValue_ = false; // FIX HERE ?
					return true;
				} catch (...) {
					return false;
				}
			}

			virtual std::string print_value() const {
				return emptyValue_ ? "" : stringify(value); // FIX HERE ?
			}

			std::function<T(CallbackArgs&)> callback;
			T value;
		private: // FIX HERE ?
			bool emptyValue_ = true; 
		};

  1. Remove the member variable and do not check callback() return code
callback(args);
  1. Use local variable, get the result of callback() then void it:
T value = callback(args);
(void) value;
return true;

from cmdparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.